New issue
Advanced search Search tips

Issue 766735 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

TabsTest.testHideKeyboardWhenOpeningWindow very flaky since ~2017-09-18T21:00:00Z

Project Member Reported by jbudorick@chromium.org, Sep 19 2017

Issue description

^^^

typical failure mode is:

junit.framework.AssertionFailedError: expected keyboard show: false
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138)
	at org.chromium.chrome.browser.TabsTest.assertWaitForKeyboardStatus(TabsTest.java:251)
	at org.chromium.chrome.browser.TabsTest.testHideKeyboardWhenOpeningWindow(TabsTest.java:322)
	at java.lang.reflect.Method.invokeNative(Method.java)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

from https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/46011

disabling.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ecb4a43428a544f003817f66343a84c0bc37aa

commit 53ecb4a43428a544f003817f66343a84c0bc37aa
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Sep 19 18:25:13 2017

[android] Disable TabsTest.testHideKeyboardWhenOpeningWindow.

TBR=tedchoc@chromium.org

Bug: 766735
Change-Id: If59ee5466605f5ced604b96fe1a74c73e3536325
Reviewed-on: https://chromium-review.googlesource.com/673349
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502898}
[modify] https://crrev.com/53ecb4a43428a544f003817f66343a84c0bc37aa/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Cc: jbudorick@chromium.org
Owner: agrieve@chromium.org
Status: Assigned (was: Started)
I suspect this is due to proguard obfuscation of chrome_public_test_apk, though I don't yet have a theory as to the mechanism. Evidence is somewhat circumstantial and somewhat experimental:
 - the CL is in the blamelist for the first failure of this test on Android Tests: https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/46004
 - the try run for the CL had two failures of this test before its success (thanks @RetryOnFailure). See TabsTest in https://storage.cloud.google.com/chromium-result-details/html/chrome_public_test_apk_linux_android_rel_ng_387179_2017_09_18_T18_19_46-UTC (from https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/linux_android_rel_ng/387179)
 - I'm able to reproduce inconsistently but at a high rate w/ obfuscation enabled. I am not able to reproduce at all after reverting locally.

Sign in to add a comment