New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766732 link

Starred by 4 users
Status: Started
Owner:
wolenetz@chromium.org
Cc:
█ servolk@chromium.org
dalecur...@chromium.org
chcunningham@chromium.org
wolenetz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

CurrentTime becomes whatever duration was when all SourceBuffers are removed from MediaSource

Project Member Reported by wolenetz@chromium.org, Sep 19 2017 
1. Start an MSE playback (without using endOfStream()).
2. Set MediaSource duration to Infinity.
3. remove all SourceBuffers from the MediaSource

Observe:
Element stops rendering media.
But currentTime attribute is now Infinity.

Questions:
a) What should the currentTime value be set to when there are no SourceBuffers? I suspect at least Infinity shouldn't be allowed.
b) Ditto for when there is a SourceBuffer(s) but no SourceBuffer is in activeSourceBuffers. I suspect that the most recent currentTime should be retained. (Perhaps here and in (a), above.)

Comment 1 by joseph.l...@samsung.com, Oct 31 2017 

I interested to work on this issue.

I have analyzed this issue,

WebMediaPlayerImpl
/ TODO(scherkus): Replace with an explicit ended signal to HTMLMediaElement,
   // see  http://crbug.com/409280 
   // Note: Duration() may be infinity.

Returning Infinity value from WebMediaPlayerImpl
::CurrentTime() should be corrected(CurrentTime can't be infinity).

And need to handle playback ended explicit check from HTMLMediaElement if duration is Infinity..

Comment 2 by joseph.l...@samsung.com, Nov 2 2017 

I have pushed patch to resolve this issue,

https://chromium-review.googlesource.com/c/chromium/src/+/750526
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/918863bc4660aa0cc992b6cb7d4611bb4809e6a6

commit 918863bc4660aa0cc992b6cb7d4611bb4809e6a6
Author: josephlolak <joseph.lolak@samsung.com>
Date: Wed Nov 15 08:54:33 2017

Fix for incorrect currenttime if media duration is infinity

Returned last played time if media duration is infinity.
And modified WMPI unit test "InfiniteDuration".

Bug: 766732, 409280 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic5b2554cb7fddd6938309f08dfd5746bc89c56b4
Reviewed-on: https://chromium-review.googlesource.com/750526
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516645}
[modify] https://crrev.com/918863bc4660aa0cc992b6cb7d4611bb4809e6a6/AUTHORS
[modify] https://crrev.com/918863bc4660aa0cc992b6cb7d4611bb4809e6a6/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/918863bc4660aa0cc992b6cb7d4611bb4809e6a6/media/blink/webmediaplayer_impl_unittest.cc
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 15

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dbbrooks@chromium.org, Today (19 hours ago)

Owner: wolenetz@chromium.org
Status: Started (was: Untriaged)
wolenetz@, could you confirm whether this issue was fixed? I don't want to presume, but would be nice to close this one given its age. Thanks.
►

Sign in to add a comment