New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766727 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Task



Sign in to add a comment

Remove unnecessary powerd prefs

Project Member Reported by derat@chromium.org, Sep 19 2017

Issue description

Some powerd prefs can probably be removed in favor of detecting hardware features at runtime. I should do a full audit, but off the top of my head:

- has_keyboard_backlight: powerd supports hotpluggable keyboard backlights now ( issue 749539 ), and I suspect we can always enable that path now.

- set_wifi_transmit_power_for_tablet_mode: powerd knows if there's a tablet mode switch or not, so I don't know why we need this.

- external_display_only: powerd can detect the presence of an internal display, I think (and it already watches udev events about displays getting connected and disconnected). It knows if it's found an internal backlight or not, although I'm not sure if we should use that to make the decision.

I may be able to delete some USE flags as part of this as well. I need to be careful since I believe that some hardware doesn't appear immediately at boot -- I've seen this happen with ambient light sensors, for instance, and powerd currently defers making its initial backlight brightness adjustment if it expects an ALS to show up eventually.
 

Sign in to add a comment