New issue
Advanced search Search tips

Issue 766725 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Test fails asan when overview and splitview mode are both active.

Project Member Reported by sammiequon@chromium.org, Sep 19 2017

Issue description

Seems to only fail when one window is snapped. Workaround currently is to ensure overview mode is left before the test ends.

 
Cc: -sammiequon@chromium.org x...@chromium.org
Owner: sammiequon@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fde26c7b89a5eadeee41e6e5b5b5252863ca864

commit 3fde26c7b89a5eadeee41e6e5b5b5252863ca864
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Oct 30 19:57:30 2017

splitview: Remove ToggleOverview at the end of some splitview tests.

This was needed previously at the end of some tests otherwise there will
be a memory leak. The introduction of SplitViewTestWindowDelegate makes
this not needed anymore.

Test: ash_unittests SplitView* with asan and without
Bug:  766725 
Change-Id: I4e9754f541719fa23250ee7f691d345f5e58bdc5
Reviewed-on: https://chromium-review.googlesource.com/744291
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512587}
[modify] https://crrev.com/3fde26c7b89a5eadeee41e6e5b5b5252863ca864/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/3fde26c7b89a5eadeee41e6e5b5b5252863ca864/ash/wm/splitview/split_view_controller_unittest.cc

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment