Fixed in https://chromium-review.googlesource.com/669484

This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I assume this is IOS only, but can you please mark all impacted OS's?

 Issue 764869  has been merged into this issue.

 Issue 764928  has been merged into this issue.

 Issue 764874  has been merged into this issue.

Hey jif@ could you assess the work involved in getting this into M62? Like how many CLs will be cherry picked?

Justin wrote an other CL that fixes a bunch of other bugs, but it's a little hacky.

To have it less hacky requires a large amount of code to be changed, so it's an other 200 loc easily.

Please let's merge the fix for this issue only for now and handle other CLs on a case by case basis.

rohitrao@ Should I merge https://bugs.chromium.org/p/chromium/issues/detail?id=766720#c9, or are there followup CLs pending?

Go ahead and merge, thanks.  There may be other fixes coming too, but nothing that should hold this one up.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a90829b7e3af82ec8f639880592859669ad7905

commit 2a90829b7e3af82ec8f639880592859669ad7905
Author: Justin Cohen <justincohen@google.com>
Date: Mon Sep 25 11:57:51 2017

[ios] Short term solution to iPhone X top layout issues for BVC.

The proper solution is to either way for ios/clean or refactor BVC to use
topLayoutGuide.  Unfortunately, this change will require more than just
replacing usinag of StatusBarHeight, it will also require refactoring various
portions of BVC so layout happens within -viewSeAreaInsetsDidChange.

Instead, take advantage of the fact that, for now, the status bar frame can be
used to fake the topLayoutGuide, and can be used at anytime.

TBR=justincohen@google.com

(cherry picked from commit b3170c396ef5c034aec1af5c4f671f3cc6b07804)

Bug:  766720 
Change-Id: I7b05ce78a0104884fb77d21be512c641b1da0e95
Reviewed-on: https://chromium-review.googlesource.com/669484
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502756}
Reviewed-on: https://chromium-review.googlesource.com/681456
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#421}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/2a90829b7e3af82ec8f639880592859669ad7905/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/2a90829b7e3af82ec8f639880592859669ad7905/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/2a90829b7e3af82ec8f639880592859669ad7905/ios/chrome/browser/ui/ui_util.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e8731c93867078fd2eb93414480619e46ce981

commit b1e8731c93867078fd2eb93414480619e46ce981
Author: Justin Cohen <justincohen@chromium.org>
Date: Mon Sep 25 12:04:19 2017

Revert "[ios] Short term solution to iPhone X top layout issues for BVC."

This reverts commit 2a90829b7e3af82ec8f639880592859669ad7905.

Reason for revert: error in resolving conflicts.

Original change's description:
> [ios] Short term solution to iPhone X top layout issues for BVC.
> 
> The proper solution is to either way for ios/clean or refactor BVC to use
> topLayoutGuide.  Unfortunately, this change will require more than just
> replacing usinag of StatusBarHeight, it will also require refactoring various
> portions of BVC so layout happens within -viewSeAreaInsetsDidChange.
> 
> Instead, take advantage of the fact that, for now, the status bar frame can be
> used to fake the topLayoutGuide, and can be used at anytime.
> 
> TBR=justincohen@google.com
> 
> (cherry picked from commit b3170c396ef5c034aec1af5c4f671f3cc6b07804)
> 
> Bug:  766720 
> Change-Id: I7b05ce78a0104884fb77d21be512c641b1da0e95
> Reviewed-on: https://chromium-review.googlesource.com/669484
> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Jean-François Geyelin <jif@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#502756}
> Reviewed-on: https://chromium-review.googlesource.com/681456
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3202@{#421}
> Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}

TBR=rohitrao@chromium.org,jif@chromium.org,marq@chromium.org,justincohen@chromium.org

Change-Id: I670c2138fa43300d54f6d178b3b53cabdac137e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  766720 
Reviewed-on: https://chromium-review.googlesource.com/681554
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#422}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/b1e8731c93867078fd2eb93414480619e46ce981/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b1e8731c93867078fd2eb93414480619e46ce981/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/b1e8731c93867078fd2eb93414480619e46ce981/ios/chrome/browser/ui/ui_util.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f7ecede5a0702a0948fdfed45a6b853e0cfd43

commit 75f7ecede5a0702a0948fdfed45a6b853e0cfd43
Author: Justin Cohen <justincohen@google.com>
Date: Mon Sep 25 13:11:00 2017

[ios] Short term solution to iPhone X top layout issues for BVC.

The proper solution is to either way for ios/clean or refactor BVC to use
topLayoutGuide.  Unfortunately, this change will require more than just
replacing using of StatusBarHeight, it will also require refactoring various
portions of BVC so layout happens within -viewSeAreaInsetsDidChange.

Instead, take advantage of the fact that, for now, the status bar frame can be
used to fake the topLayoutGuide, and can be used at anytime.

Bug:  766720 
Change-Id: I5f50f7580854c2dfa37d9c48206bc0f27e814e5f
Reviewed-on: https://chromium-review.googlesource.com/669484
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/681417
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#423}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/75f7ecede5a0702a0948fdfed45a6b853e0cfd43/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/75f7ecede5a0702a0948fdfed45a6b853e0cfd43/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/75f7ecede5a0702a0948fdfed45a6b853e0cfd43/ios/chrome/browser/ui/ui_util.mm