New issue
Advanced search Search tips

Issue 766712 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Caption buttons in the Files app window frame do nothing.

Project Member Reported by msw@chromium.org, Sep 19 2017

Issue description

mash: Caption buttons in the Files app window frame do nothing.

On ToT @ #502676 build chrome and mash:all
(1) Run chrome --mash (and --disable-features=EnableFullscreenAppList)
(2) Open the Files app from the app list
(3) Click minimize/maximize/close in the top right of the window
Expected: Caption buttons do something.
Actual: Caption buttons do nothing.

This likely affects other apps with custom frames.
 

Comment 1 by sashab@chromium.org, Feb 23 2018

Components: -Platform>Apps>FileManager
Is this a FileManager-specific bug? Removing the FileManager component because I think this is a bug that would affect all custom-frame Chrome Apps.

Comment 2 by msw@chromium.org, Feb 23 2018

This still repros and is probably applicable to all custom-frame containers.

Comment 3 by msw@chromium.org, Feb 23 2018

Components: MUS

Comment 4 by msw@chromium.org, Feb 23 2018

Cc: jamescook@chromium.org sky@chromium.org
Scott mentioned that this is probably an issue with the frame's non-client area. Ash is probably rendering the caption buttons, and so Ash should get events for those views, but the app is getting the events instead.
Components: -MUS Internals>Services>WindowService
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1145abadfce5c466cdff408925707a99a0d24a89

commit 1145abadfce5c466cdff408925707a99a0d24a89
Author: Evan Stade <estade@chromium.org>
Date: Tue Apr 24 14:09:08 2018

Mash: fix colored app window frames.

Previously, in Mash, Ash used an EmptyDraggableNonClientFrameView and
Chrome drew an AppWindowFrameView on top of that. Events went to the
former, which didn't know about caption buttons, and AppWindowFrameView
draws Windows-style caption buttons, so both appearance and behavior
were broken. (In classic Ash, Chrome uses a CustomFrameViewAsh.)

Now, in Mash, Chrome doesn't have a NonClientFrameView, but tells Ash
about the frame's colors via mus init properties. The Ash-process
CustomFrameViewAsh will be painted correctly and be able to handle
events.

Bug:  766712 
Change-Id: Ic272e5755d0ac9af325b512bb0c3ccbe87fcb2c8
Reviewed-on: https://chromium-review.googlesource.com/1023036
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553088}
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/ash/wm/property_util.cc
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/ash/wm/property_util.h
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/chrome/browser/ui/views/apps/chrome_native_app_window_views.h
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/1145abadfce5c466cdff408925707a99a0d24a89/services/ui/public/interfaces/window_manager.mojom

Comment 8 by est...@chromium.org, Apr 24 2018

Owner: est...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment