@fdoray : just realized we have base::DisallowWaiting(), base::DisallowBaseSyncPrimitives(), and base::SetWaitAllowed(). Can we coalesce these please :)?
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/78d31c19a31277dc9690df98c7c1c64009256695
commit 78d31c19a31277dc9690df98c7c1c64009256695
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Thu Nov 08 03:26:58 2018
[TaskScheudler]: Migrate off of ScopedAllowWait in /gpu
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.
It should have been replaced by :
* base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
* base::ScopedAllowSyncPrimitives in non-test files
* base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.
Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533
Please CQ if LGTY!
This CL was uploaded by git cl split.
R=piman@chromium.org
Bug: 766678
Change-Id: I6f4e77e4d48a29afc52709cf1c1b82ef08be7f98
Reviewed-on: https://chromium-review.googlesource.com/c/1325229
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606315}
[modify] https://crrev.com/78d31c19a31277dc9690df98c7c1c64009256695/gpu/ipc/client/gpu_channel_host.cc
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/48a2f8302e2d232721a80641fa60fd6116672c94
commit 48a2f8302e2d232721a80641fa60fd6116672c94
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Thu Nov 08 16:20:24 2018
[TaskScheduler]: Migrate off of ScopedAllowWait in /content/browser/browser_main_loop.cc
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.
It should have been replaced by :
* base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
* base::ScopedAllowBaseSyncPrimitives in non-test files
* base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.
Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533
Please CQ if LGTY!
This CL was uploaded by git cl split.
R=gab@chromium.org
Bug: 766678
Change-Id: I51b024db95473edf6ee3efb82879c95be92b9191
Reviewed-on: https://chromium-review.googlesource.com/c/1325219
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606490}
[modify] https://crrev.com/48a2f8302e2d232721a80641fa60fd6116672c94/content/browser/browser_main_loop.cc
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/2429b3291ae78971bd6478bacf7c75db857ba961
commit 2429b3291ae78971bd6478bacf7c75db857ba961
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Thu Nov 08 17:27:59 2018
[TaskScheduler]: Migrate off of ScopedAllowWait in /remoting
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.
It should have been replaced by :
* base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
* base::ScopedAllowSyncPrimitives in non-test files
* base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.
Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533
Please CQ if LGTY!
This CL was uploaded by git cl split.
R=sergeyu@chromium.org
Bug: 766678
Change-Id: I769a4567e23b45976732ec447889eeb683faf68b
Reviewed-on: https://chromium-review.googlesource.com/c/1324917
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606513}
[modify] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/remoting/base/auto_thread.cc
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/80813c4fbe697febcdc6ef1041bdf54b3a05cc27
commit 80813c4fbe697febcdc6ef1041bdf54b3a05cc27
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Fri Nov 09 18:22:24 2018
[TaskScheduler]: Migrate off of ScopedAllowWait in /content/public/test
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.
It should have been replaced by :
* base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
* base::ScopedAllowSyncPrimitives in non-test files
* base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.
Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533
Please CQ if LGTY!
This CL was uploaded by git cl split.
R=sky@chromium.org
Bug: 766678
Change-Id: I3b6193072a7049433d38a61ff62c1f34454c7b5e
Reviewed-on: https://chromium-review.googlesource.com/c/1324454
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606900}
[modify] https://crrev.com/80813c4fbe697febcdc6ef1041bdf54b3a05cc27/content/public/test/browser_test_base.cc
Comment 1 by bugdroid1@chromium.org
, Sep 25 2017