New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766677 link

Starred by 2 users
Status: Fixed
Owner:
maxmorin@chromium.org
Closed: Oct 2017
Cc:
█ olka@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AudioOutputController doesn't take stream recreation into account when checking if a stream wedged

Project Member Reported by maxmorin@chromium.org, Sep 19 2017 
Consider the following sequence of events:

1. DoCreate and DoPlay is called.
2. Stream is working, so |on_more_io_data_called_| is set and eventually a success is logged for Media.AudioOutputControllerPlaybackStartupSuccess.
So far, so good.
3. DoCreate and DoPlay is called due to device change.
4. Stream is dead, but |on_more_io_data_called_| was never reset so success is still logged for Media.AudioOutputControllerPlaybackStartupSuccess. That doesn't make sense.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c300ce60477c08297a3a2ea737dc7a7fab53d3

commit 14c300ce60477c08297a3a2ea737dc7a7fab53d3
Author: maxmorin <maxmorin@chromium.org>
Date: Fri Oct 06 10:56:48 2017

Fix OutputControllerStartupSuccess logic.

This CL moves the counter/timer into ErrorStatisticsTracker so that the
counter is appropriately reset every time the stream is recreated. Also
fixes an issue where the CallbackError stats were logged per play/pause
cycle, rather than per stream.

BUG= 766677 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I16e5dc10d14bbe766de467174a9ee4a3c438bf47
Reviewed-on: https://chromium-review.googlesource.com/697426
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507028}
[modify] https://crrev.com/14c300ce60477c08297a3a2ea737dc7a7fab53d3/media/audio/audio_output_controller.cc
[modify] https://crrev.com/14c300ce60477c08297a3a2ea737dc7a7fab53d3/media/audio/audio_output_controller.h

Comment 2 by maxmorin@chromium.org, Oct 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment