New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766672 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Form autofill accessory view needs to honor the iPhone X's safe area.

Project Member Reported by jif@chromium.org, Sep 19 2017

Issue description

For example, the 'x' next to the up and down arrows is missing.
 
Screen Shot 2017-09-19 at 14.57.56.png
68.6 KB View Download

Comment 1 by pkl@chromium.org, Sep 20 2017

Labels: M-63
It's bad that "x" isn't showing in landscape, but it affects only landscape in "this" orientation. Easy workaround if you rotate device by 180 degrees (still landscape), the notch is on the other side and the "x" is visible.

Comment 2 by lod@chromium.org, Oct 11 2017

Owner: lod@chromium.org
Status: Started (was: Assigned)

Comment 3 by cma...@chromium.org, Oct 19 2017

Hey lod@ are you making some progress on this issue?

Comment 4 by lod@chromium.org, Oct 19 2017

Yes, close to done but I'm at a summit today/yesterday and was traveling tuesday. Hoping to get the CL out by tomorrow.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87

commit fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87
Author: Elodie Banel <lod@google.com>
Date: Wed Oct 25 10:03:23 2017

Use autolayout and safearealayoutguide for form input accessory view.

Rewrite the view to use autolayout in order to use safearealayoutguide
for iPhone X compatibility.
While writing this CL I identified a lot of dead code here which should
be removed in a future CL: the entire use of left and right frames for
split keyboard applies only for iPads running on iOS < 9, which aren't
supported. I will do a follow up CL removing it.

Bug:  766672 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If24919202cac92ee89b3e306c26e622efb60262b
Reviewed-on: https://chromium-review.googlesource.com/721325
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511410}
[modify] https://crrev.com/fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87/ios/chrome/browser/autofill/form_input_accessory_view.h
[modify] https://crrev.com/fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Comment 6 by lod@chromium.org, Oct 25 2017

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ed689abe3791553a08a8f23bb6434aa75025f9

commit 69ed689abe3791553a08a8f23bb6434aa75025f9
Author: Elodie Banel <lod@chromium.org>
Date: Wed Oct 25 14:31:12 2017

Revert "Use autolayout and safearealayoutguide for form input accessory view."

This reverts commit fcd3b3e8dd1b53bbe4efd5ac3c14bbd72c62dc87.

Reason for revert: Accessibility is broken on ios 9.

Original change's description:
> Use autolayout and safearealayoutguide for form input accessory view.
> 
> Rewrite the view to use autolayout in order to use safearealayoutguide
> for iPhone X compatibility.
> While writing this CL I identified a lot of dead code here which should
> be removed in a future CL: the entire use of left and right frames for
> split keyboard applies only for iPads running on iOS < 9, which aren't
> supported. I will do a follow up CL removing it.
> 
> Bug:  766672 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: If24919202cac92ee89b3e306c26e622efb60262b
> Reviewed-on: https://chromium-review.googlesource.com/721325
> Commit-Queue: Elodie Banel <lod@chromium.org>
> Reviewed-by: Jean-François Geyelin <jif@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511410}

TBR=jif@chromium.org,lod@chromium.org,mahmadi@chromium.org

Change-Id: I620903572213ede12e7e0fb2a6b01d31af9a6c6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  766672 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/738250
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511448}
[modify] https://crrev.com/69ed689abe3791553a08a8f23bb6434aa75025f9/ios/chrome/browser/autofill/form_input_accessory_view.h
[modify] https://crrev.com/69ed689abe3791553a08a8f23bb6434aa75025f9/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/69ed689abe3791553a08a8f23bb6434aa75025f9/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb6b7878b5aead7fc444fb4ab346bbe2d8975fed

commit fb6b7878b5aead7fc444fb4ab346bbe2d8975fed
Author: Elodie Banel <lod@google.com>
Date: Thu Oct 26 09:12:19 2017

Reland Use autolayout and safearealayoutguide for form input accessory view.

Initialisation of view after adding to parent view resulted in
the view not having accessibility labels correctly set on iOS 9.
An alternative fix was to call "setNeedsLayout" after initialisation.

Bug:  766672 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1bdcfb13d628e383078dfb27b7a9404b6de08233
Reviewed-on: https://chromium-review.googlesource.com/737880
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511769}
[modify] https://crrev.com/fb6b7878b5aead7fc444fb4ab346bbe2d8975fed/ios/chrome/browser/autofill/form_input_accessory_view.h
[modify] https://crrev.com/fb6b7878b5aead7fc444fb4ab346bbe2d8975fed/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/fb6b7878b5aead7fc444fb4ab346bbe2d8975fed/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Comment 9 Deleted

Status: Verified (was: Fixed)
Autofill keyboard accessory respects the safe area.
https://drive.google.com/file/d/1yDqRMVAYItSdrMlMQybl4Ag9hNwypd0Z/view
Verified on build M64.0.3254.0 canary
Device: iPhoneX Simulator.

Sign in to add a comment