chrome://settings/cupsPrinters is sometimes empty on relogin |
||||
Issue descriptionChrome Version: ToT OS: ChromeOS What steps will reproduce the problem? (0) have a printer configured (1) open chrome://settings/cupsPrinters (2) logout (3) login What is the expected result? List of configured printers. What happens instead? Sometimes the list of printers is empty. There's a race here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/synced_printers_manager.cc?l=62 If we call this before PrintersSyncBridge is initialized we're gonna have a bad time.
,
Sep 20 2017
That's easily checked with a log statements at the point of writing: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/printers_sync_bridge.cc?type=cs&q=OnReadAllData&l=110 and reading: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/cups_printers_manager.cc?type=cs&q=GetConfiguredPrinters&l=97
,
Sep 20 2017
,
Sep 21 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a533cf6b8bfd6b8fa7393c8b09d44e0c5c8fbd0 commit 5a533cf6b8bfd6b8fa7393c8b09d44e0c5c8fbd0 Author: Vladislav Kuzkokov <vkuzkokov@chromium.org> Date: Thu Oct 12 13:13:44 2017 Fix race in SyncedPrintersManager. If SyncedPrintersManagerImpl is created before PrintersSyncBridge read printers, we get an empty list. Bug: 766661 Change-Id: Ia728180e1e11b290f5c8ce3da5a89d6d864c1264 Reviewed-on: https://chromium-review.googlesource.com/675114 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#508330} [modify] https://crrev.com/5a533cf6b8bfd6b8fa7393c8b09d44e0c5c8fbd0/chrome/browser/chromeos/printing/printers_sync_bridge.cc [modify] https://crrev.com/5a533cf6b8bfd6b8fa7393c8b09d44e0c5c8fbd0/chrome/browser/chromeos/printing/printers_sync_bridge.h [modify] https://crrev.com/5a533cf6b8bfd6b8fa7393c8b09d44e0c5c8fbd0/chrome/browser/chromeos/printing/synced_printers_manager.cc
,
Nov 3 2017
I'm fairly certain this is fixed. The commit landed in M63. Commit "5a533cf6" data not found. Looking at prefix short commits... Commit 5a533cf6... initially landed in 63.0.3239.0 No merges found. |
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Sep 19 2017