New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 756777



Sign in to add a comment

Voice search on local NTP: Use www.google.TLD as security origin

Project Member Reported by treib@chromium.org, Sep 19 2017

Issue description

Currently, the microphone permission bubble for voice search on the local NTP mentions "chrome-search://local-ntp", which is not very friendly. After discussion with security and privacy, we decided to map the permissions to the Google base URL instead, i.e. www.google.TLD.
 

Comment 1 by mastiz@chromium.org, Sep 19 2017

Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37

commit 9e4bd924b70bae12a90cf1f0bdfa15695c62ea37
Author: Marc Treib <treib@chromium.org>
Date: Mon Sep 25 08:32:13 2017

[Local NTP Voice] Use www.google.TLD as the security origin

Before this CL, the microphone permission bubble would mention
"chrome-search://local-ntp" which isn't very friendly. After this CL,
the permission gets mapped to www.google.TLD (the Google base URL)
instead.

Bug:  766659 
Change-Id: I5b8008c5e0ca063c31b0566edee9448a87be7fbc
Reviewed-on: https://chromium-review.googlesource.com/672543
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504006}
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h
[modify] https://crrev.com/9e4bd924b70bae12a90cf1f0bdfa15695c62ea37/chrome/browser/ui/search/local_ntp_browsertest.cc

Comment 3 by treib@chromium.org, Sep 28 2017

Status: Fixed (was: Started)

Sign in to add a comment