[Missing Test]: Memory leak in gpu process (type=gpu-process) with 3d PPAPI/NACL interface |
|
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: ---- https://chromium.googlesource.com/chromium/src.git/+/cc0169cd1b636d8cd1c949289242d63e5a554504 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=762860 Thank you...!!
,
Oct 15 2017
I'm not sure this is useful, but FWIW this was broken from the original commit. The correct code was lost when the callback was removed during iterations on the initial CL. Here is the exact spot where the code was broken: https://codereview.chromium.org/1943513002/diff2/80001:100001/content/renderer/pepper/ppb_graphics_3d_impl.cc
,
Oct 16 2017
Thanks. I actually had gone through and found the same, as I remember reviewing the correct code and was very surprised to find that it was broken. Talking with erikchen we were both surprised. |
|
►
Sign in to add a comment |
|
Comment 1 by piman@chromium.org
, Sep 19 2017