CSSViewportRule should be RuntimeEnabled |
||||
Issue descriptionMost of the device adaptation feature ( issue 155477 ) is behind [RuntimeEnabled=CSSViewport], but the CSSViewportRule interface isn't. This means we're the only browser to ship window.CSSViewportRule. I don't _think_ it's useful for anything (the parsing looks to be properly controlled) so it's probably not a big deal, but I could imagine people wanting to use this for feature detection. Can we just put the interface behind [RuntimeEnabled=CSSViewport]?
,
Sep 19 2017
Yes, this just sounds like a mistake
,
Sep 20 2017
@kenneth.r.christiansen@intel.com who's responsible for this feature? It looks like you worked on putting the runtime flag in - is that correct?
,
Sep 20 2017
I did. It was mostly implemented by Thiago who doesn't work on Blink any longer. Rune Lillesveen also worked on the feature at some point.
,
Sep 20 2017
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/301269461587a78cc3f2a52227852e81550d78f3 commit 301269461587a78cc3f2a52227852e81550d78f3 Author: Rune Lillesveen <rune@opera.com> Date: Thu Sep 21 06:29:34 2017 Expose CSSViewportRule only if runtime flag is enabled. Bug: 766652 Change-Id: I7e76640a397eafeba28f178fb568b3af7cdccf49 Reviewed-on: https://chromium-review.googlesource.com/674924 Reviewed-by: Rick Byers <rbyers@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#503370} [modify] https://crrev.com/301269461587a78cc3f2a52227852e81550d78f3/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/301269461587a78cc3f2a52227852e81550d78f3/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/301269461587a78cc3f2a52227852e81550d78f3/third_party/WebKit/Source/core/css/CSSViewportRule.idl
,
Sep 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbyers@chromium.org
, Sep 19 2017