New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766638 link

Starred by 2 users
Status: Fixed
Owner:
rijubrat...@intel.com
Closed: Oct 2017
Cc:
█ aleksand...@intel.com
█ hubbe@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pass texture_norm16 extension from tests to GPU

Project Member Reported by rijubrat...@intel.com, Sep 19 2017 
Pass texture_norm16 extension from tests to GPU

Right now we have put ResourceSettings::high_bit_for_testing to be false, so pixel tests are still using Luminance format.

Also, Pixel tests for R16 format will fail because 
gpu::FeatureInfo both gl_version_info_->is_desktop_core_profile (because tests use GLES context) and gl::HasExtension(extensions, "GL_EXT_texture_norm16") are false.
So validators are not added, hence validators check is failing.

Need to enable the texture_norm16 extension from TestInProcessContextProvider, so that pixel tests can can use it. 
When we actually enable R16, we can set ResourceSettings::high_bit_for_testing to be true.

Reference CL: https://chromium-review.googlesource.com/c/chromium/src/+/663660/
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7

commit c070361a7d3cfcb199f99ae9dee3f49cb47e13a7
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Sun Oct 08 12:55:34 2017

Make pixel tests pass when using R16_EXT.

Check if GL is atleast 2.1 && GL_ARB_texture_rg is present.
The test path is using OSMesa which is at 2.1 version.
Setting ResourceSettings::high_bit_for_testing to true means R16 is
going to be used for tests.

BUG= 766638 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie3d254efb14a89f5b1a174169a43aaa652cfc0f1
Reviewed-on: https://chromium-review.googlesource.com/702280
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507306}
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/c070361a7d3cfcb199f99ae9dee3f49cb47e13a7/gpu/command_buffer/service/texture_manager.cc

Comment 2 by rijubrat...@intel.com, Oct 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment