New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766571 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-5.4% regression in system_health.memory_desktop at 502252:502459

Project Member Reported by alexclarke@chromium.org, Sep 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=766571

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=339095a694b0885974caba3f6e68041d9e1b138906df8a1b4a86443e64eda75c


Bot(s) for this bug's original alert(s):

android-nexus5
chromium-rel-mac12
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

Cc: primiano@chromium.org
Owner: primiano@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author primiano@chromium.org ===

Hi primiano@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Primiano Tucci
  Commit : fde1f92076efb79d66d242e5bcdff09f6b91e09e
  Date   : Fri Sep 15 17:30:19 2017
  Subject: memory-infra: Send ProcessMemoryDumps to the service

Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/long_running_tools/long_running_tools_gmail-foreground
  Change       : 6.80% | 48919827.701 -> 52247119.8284

Revision             Result                   N
chromium@502293      48919828 +- 2310206      6      good
chromium@502295      48547906 +- 310395       6      good
chromium@502296      54747450 +- 8562184      6      bad       <--
chromium@502297      53832331 +- 8843702      6      bad
chromium@502300      51672086 +- 751456       6      bad
chromium@502307      52717722 +- 6281375      6      bad
chromium@502321      51638969 +- 687543       6      bad
chromium@502349      52424119 +- 6165997      6      bad
chromium@502404      52247120 +- 5015799      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=long.running.tools.gmail.foreground system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968030509306422720


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

 Issue 766566  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Sep 20 2017

 Issue 766565  has been merged into this issue.
Cc: lalitm@chromium.org hjd@chromium.org
Owner: lalitm@chromium.org
Lalit, can you take a look to see if the regressions are genuine or due to the MDP dump order?

Ignore the mac one, that one I know what is about and we have a plan in Issue 760777

Comment 7 by lalitm@chromium.org, Sep 20 2017

Status: Started (was: Assigned)
Taking a look now!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Sep 20 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Primiano Tucci
  Commit : fde1f92076efb79d66d242e5bcdff09f6b91e09e
  Date   : Fri Sep 15 17:30:19 2017
  Subject: memory-infra: Send ProcessMemoryDumps to the service

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/foreground/http_m_youtube_com_results_q_science
  Change       : 2.43% | 18919146.2222 -> 19382744.0

Revision             Result                   N
chromium@502251      18919146 +- 102896       9       good
chromium@502277      18934024 +- 81034.7      14      good
chromium@502290      18930468 +- 53514.2      9       good
chromium@502294      18932787 +- 55082.5      6       good
chromium@502295      18912939 +- 148857       6       good
chromium@502296      19192512 +- 582720       6       bad       <--
chromium@502297      19326977 +- 767459       6       bad
chromium@502303      19366555 +- 939208       9       bad
chromium@502355      19289023 +- 350324       6       bad
chromium@502459      19382744 +- 677968       6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8967911267701728816


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Sep 23 2017

Cc: benhenry@google.com
 Issue 768068  has been merged into this issue.
This is still on my radar. Currently trying to acquire a device from Skylab so that I can reproduce this issue.
Lalit, any update on this bug?
I got sidetracked with other stuff so no updates. I'll come back to this when my current piece of work is completed.
Components: Speed>Metrics>SystemHealthRegressions
Components: -Speed>Metrics>SystemHealthRegressions

Sign in to add a comment