New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766570 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

factory: Fail to load initial UI.

Project Member Reported by hungte@chromium.org, Sep 19 2017

Issue description

On ToT, Chrome will block if initial URL is extension, showing 
 
 <factory_test_extension_id> is blocked
 Requests to the server have been blocked by an extension
 Try disabling your extensions.
 ERR_BLOCKED_BY_CLIENT
   [Reload]

If we set init page to http://localhost:4012 then it would work, but due to  http://crbug.com/627372 , we won't be able to get focus in the first created window.

If we use Chrome remote debugging protocol (chrome_openurl in factory bin) then the window will have focus properly.
 

Comment 1 by hungte@chromium.org, Sep 19 2017

Cc: chromeos-factory-eng@google.com
Components: Factory
One possible solution is to let goofy invoke chrome_openurl when some special event is found, and change restarting.html to use that for loading new page.

Comment 2 by hungte@chromium.org, Sep 19 2017

 Issue 766568  has been merged into this issue.

Comment 3 by hungte@chromium.org, Sep 19 2017

Labels: -Pri-3 Pri-0
ToT is broken and this is indeed a P0 issue. We need some immediate solution, or we'll have to change the init url from extension page to http://localhost:4012, with the issue that focus can't be set.
Create a chrome app with a webview can get focus correctly.

Not sure if this will introduce new bugs..

Comment 5 by hungte@chromium.org, Sep 20 2017

Owner: pihsun@chromium.org
Status: Assigned (was: Untriaged)
pihsun has a one line change. let's use it first :)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3a0644b1c46979b8dea320efd5035231a1728da6

commit 3a0644b1c46979b8dea320efd5035231a1728da6
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Sep 20 18:30:22 2017

Fix the extension is blocked problem on initial UI.

Chrome browser can't load initial URL in extension on ToT, and would
show a "<factory_test_extension_id> is blocked" page.

To work around this and have correct focus for first page, we create a
data URL that would connect to remote debugger, open a new tab to
factory UI, and close itself.

BUG= chromium:766570 ,b:65811583
TEST=make test
TEST=manually on DUT, reboot and check the focus is correct by
     ctrl-alt-0.

Change-Id: Ifc7435b74622883c0be7aa4ac1067b0844e38ce0
Reviewed-on: https://chromium-review.googlesource.com/674468
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Commit-Ready: Chia-Hsiu Chang <chia-hsiu.chang@quantatw.com>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/3a0644b1c46979b8dea320efd5035231a1728da6/init/goofy.d/monolithic/chrome_dev.conf

Comment 7 by hungte@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment