New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766562 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 690042



Sign in to add a comment

14.2% regression in system_health.memory_mobile at 502231:502268

Project Member Reported by alexclarke@chromium.org, Sep 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=766562

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=25335dd4661218853c40865876b0c44696b16d3819864d12177bcc088a218d1a


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

Cc: rdevlin....@chromium.org
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author rdevlin.cronin@chromium.org ===

Hi rdevlin.cronin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Devlin Cronin
  Commit : 282ea833bef8dbf11acfa618d06568a910242c4d
  Date   : Fri Sep 15 14:41:26 2017
  Subject: [Extensions Bindings] Remove unused test member event_change_handler_

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_imgur
  Change       : 11.57% | 5380096.0 -> 6002688.0

Revision             Result                 N
chromium@502230      5380096 +- 251879      6      good
chromium@502249      5524992 +- 306228      6      good
chromium@502250      6436523 +- 202445      6      bad       <--
chromium@502251      6422187 +- 173939      6      bad
chromium@502252      6198272 +- 367683      6      bad
chromium@502254      6667264 +- 284355      6      bad
chromium@502259      6497280 +- 248138      6      bad
chromium@502268      6002688 +- 221392      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968030600201820928


For feedback, file a bug with component Speed>Bisection
Looks like a bad bisect, lets try again.
Cc: perezju@chromium.org
Also cc-ing perezju: more java heap bisect weirdness :(
Owner: ----
Status: Untriaged (was: Assigned)
Yep, definitely not revision 282ea833bef8dbf11acfa618d06568a910242c4d. :)
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Sep 19 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_imgur


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968021018322069424


For feedback, file a bug with component Speed>Bisection
One last try.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

Cc: pdr@chromium.org
Owner: pdr@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author pdr@chromium.org ===

Hi pdr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Philip Rogers
  Commit : 89301e1190efd4d3ae2f3c1c0348a6d9d75e6477
  Date   : Thu Sep 14 23:33:06 2017
  Subject: Make DataTransfer::DeviceSpaceBounds operate on the entire rect

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_imgur
  Change       : 9.57% | 5201237.33333 -> 5698901.33333

Revision             Result                 N
chromium@502100      5201237 +- 211444      6      good
chromium@502101      6505472 +- 305530      6      bad       <--
chromium@502102      6401707 +- 222821      6      bad
chromium@502104      6280875 +- 451803      6      bad
chromium@502107      6049451 +- 230446      6      bad
chromium@502113      5889024 +- 258649      6      bad
chromium@502125      5886293 +- 320401      6      bad
chromium@502150      5819392 +- 431025      6      bad
chromium@502200      5540864 +- 604639      6      bad
chromium@502300      5698901 +- 213123      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968012488229880992


For feedback, file a bug with component Speed>Bisection
Owner: perezju@chromium.org
perezju: java heap not bisecting.
Blockedon: 690042
Also no real regression here, sorry for the noise.
Status: WontFix (was: Assigned)

Sign in to add a comment