Issue metadata
Sign in to add a comment
|
98.2% regression in blink_perf.canvas at 502079:502153 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 19 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a92fcfb80000
,
Sep 22 2017
Looks like the job just stopped running. Filed https://github.com/catapult-project/catapult/issues/3891 for that. I'll re-kick the bisect as well.
,
Sep 22 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14af21c0780000
,
Sep 22 2017
๐ Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/14af21c0780000 Found significant differences after 1 commit: gpu: don't allow reentrancy in GpuChannelHost::Send By piman@chromium.org ยท Fri Sep 15 01:26:06 2017 chromium@b5edb4f2db00acedc8726ba4fbdcbf03a9ae7d49
,
Sep 22 2017
Assigning to piman per #5
,
Sep 22 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c70d88780000
,
Sep 22 2017
I will investigate. I suspect something was fishy before my patch and somehow it fixed it. The historical number was ~2200-2400 runs/s. Recently there was a massive improvement to ~400000 runs/s at https://chromium.googlesource.com/chromium/src/+log/a7d11af324c214dc2c64cc1dbfbb8d3772831a3f%5E..14cb93b47f330a39bf34613f1b921407324bf694?pretty=fuller&n=1000 After my patch the number goes back down to between 2300 and 4600 (seems a bit of a bimodal distribution, but not worse than the historical number). I just don't believe the ~400000 number :)
,
Sep 22 2017
๐ Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/12c70d88780000 Found significant differences after 1 commit: [Mac] A potential fix for WaitableEvent::WaitMany on macOS 10.11. By rsesek@chromium.org ยท Mon Aug 28 19:51:25 2017 chromium@5cd8eef498e28e1aacb9109645c001bbbfe1bc26
,
Sep 22 2017
What caused the numbers to go crazy is this patch on #9. After that patch a lot of results look like things go infinitely fast, skewing the overall number. That doesn't happen any more after my patch and things go back to normal
,
Sep 25 2017
I would like to understand exactly what's happening before closing, because the original regression seems bad, and might affect 62 - my patch was not intended to fix anything specifically in that area. However I'm running into https://bugs.chromium.org/p/chromium/issues/detail?id=768530 which means I can't get traces from the bot. I will try to repro locally but I don't have the exact same spec.
,
Sep 25 2017
I reproduced some of the effects locally. It looks like the crazy numbers happen when the video is restarting after the loop. Depending on timing, it may or may not happen during the test. If the test gets a little slower, then the video end and restart happen during the test loop, giving a couple (out of 20) out-of-whack measurements (1000x faster), which completely skew the results and gives better numbers (when they should be worse). Specifically, one thing that seems to largely affect the measurement is GpuChannelHost::Send (for sync messages) which is called every time. Before my patch, it used to call WaitableEvent::WaitMany, which was changed on that config (Mac 10.11) by rsesek's 5cd8eef498e28e1aacb9109645c001bbbfe1bc26 - I assume it made it a tad slower, bringing the video looping behavior into the test loop. It was also changed by my patch, which makes it faster on platforms I looked at (Linux, Mac 10.12), which would kick the looping behavior out of the test loop. I can confirm if I can grab traces after crbug.com/768530 is fixed. Locally (MBP on 10.12), I was able to get much more consistent numbers by slowing down the video (adding 'videoElement.playbackRate = 0.1;' to the source), which doesn't really affect what the benchmark measures, but makes sure the video doesn't loop. I got an improvement by about 8% (8737 vs 8099 avg) from my patch. I filed crbug.com/768587 about the benchmark issue Bottom-line: this was a progression rather than a regression, but the test behaves poorly. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 19 2017