Issue metadata
Sign in to add a comment
|
1.5%-2.9% regression in memory.top_10_mobile at 501781:501962 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8968030804252876208
,
Sep 20 2017
=== Auto-CCing suspected CL author yukiy@google.com === Hi yukiy@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : yukiy Commit : b8895fa6e92daaaf6d4d2c13ae1d358bc056aea5 Date : Thu Sep 14 04:28:17 2017 Subject: Reland Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished ( https://chromiumcodereview.appspot.com/3012573002 ) Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_https_m_facebook_com_rihanna Change : 3.05% | 2623754.66667 -> 2703741.33333 Revision Result N chromium@501862 2623755 +- 58.4237 6 good chromium@501887 2623755 +- 58.4237 6 good chromium@501894 2623787 +- 73.9008 6 good chromium@501896 2623744 +- 0.0 6 good chromium@501896,catapult@b8895fa6e9 2694024 +- 36140.4 6 bad <-- chromium@501896,catapult@4647bb4807 2694135 +- 37403.8 6 bad chromium@501897 2698803 +- 37062.9 6 bad chromium@501900 2693653 +- 36774.8 6 bad chromium@501912 2693527 +- 36959.1 6 bad chromium@501962 2703741 +- 35676.7 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8968030804252876208 For feedback, file a bug with component Speed>Bisection
,
Sep 21 2017
Issue 766548 has been merged into this issue.
,
Sep 22 2017
This regression is occurred by my change on telemetry itself, and it doesn't affect the speed metrics, but small amount of difference on memory usage before/after the patch is expected since the following script is injected through devtools protocol. https://codereview.chromium.org/3010183002/diff/340001/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 19 2017