New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766546 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5%-2.9% regression in memory.top_10_mobile at 501781:501962

Project Member Reported by alexclarke@chromium.org, Sep 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=766546

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cc9f16f9bb4008ae9ba704dcb5006be783a7012803ccc49204fef065b3c88e87


Bot(s) for this bug's original alert(s):

android-nexus5X
android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 20 2017

Cc: yukiy@google.com
Owner: yukiy@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author yukiy@google.com ===

Hi yukiy@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : yukiy
  Commit : b8895fa6e92daaaf6d4d2c13ae1d358bc056aea5
  Date   : Thu Sep 14 04:28:17 2017
  Subject: Reland Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished ( https://chromiumcodereview.appspot.com/3012573002 )

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_https_m_facebook_com_rihanna
  Change       : 3.05% | 2623754.66667 -> 2703741.33333

Revision                                 Result                  N
chromium@501862                          2623755 +- 58.4237      6      good
chromium@501887                          2623755 +- 58.4237      6      good
chromium@501894                          2623787 +- 73.9008      6      good
chromium@501896                          2623744 +- 0.0          6      good
chromium@501896,catapult@b8895fa6e9      2694024 +- 36140.4      6      bad       <--
chromium@501896,catapult@4647bb4807      2694135 +- 37403.8      6      bad
chromium@501897                          2698803 +- 37062.9      6      bad
chromium@501900                          2693653 +- 36774.8      6      bad
chromium@501912                          2693527 +- 36959.1      6      bad
chromium@501962                          2703741 +- 35676.7      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968030804252876208


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 21 2017

 Issue 766548  has been merged into this issue.

Comment 5 by yukiy@google.com, Sep 22 2017

Status: WontFix (was: Assigned)
This regression is occurred by my change on telemetry itself, and it doesn't affect the speed metrics, but small amount of difference on memory usage before/after the patch is expected since the following script is injected through devtools protocol.
https://codereview.chromium.org/3010183002/diff/340001/telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js

Sign in to add a comment