[root layer scrolls] http/tests/devtools/layers/... crashes |
|||
Issue descriptionAll the following layout tests are crashing with --root-layer-scrolls: http/tests/devtools/layers/layer-canvas-log.html http/tests/devtools/layers/layer-compositing-reasons.html http/tests/devtools/layers/layer-replay-scale.html http/tests/devtools/layers/layer-scroll-rects-get.html http/tests/devtools/layers/layer-sticky-position-constraint-get.html http/tests/devtools/layers/layer-tree-model.html http/tests/devtools/layers/layers-3d-view-hit-testing.html http/tests/devtools/layers/layers-panel-mouse-events.html http/tests/devtools/layers/no-overlay-layers.html These constitute the majority of crashing layout tests for RLS. They're probably all crashing for the same reason. Here's an example crash stack: #4 0x7fbb8344034c blink::GraphicsLayer::PlatformLayer() #5 0x7fbb85931188 blink::InspectorLayerTreeAgent::BuildLayerTree() #6 0x7fbb85930ea3 blink::InspectorLayerTreeAgent::LayerTreeDidChange() #7 0x7fbb85930e5c blink::InspectorLayerTreeAgent::enable() #8 0x7fbb85930fb0 blink::InspectorLayerTreeAgent::enable() #9 0x7fbb86775c5c blink::protocol::LayerTree::DispatcherImpl::enable() #10 0x7fbb86775abd blink::protocol::LayerTree::DispatcherImpl::dispatch() #11 0x7fbb8681edad blink::protocol::UberDispatcher::dispatch() #12 0x7fbb8598e2b0 blink::InspectorSession::DispatchProtocolMessage() #13 0x7fbb8533d4ee blink::WebDevToolsAgentImpl::DispatchMessageFromFrontend() #14 0x7fbb8533d34e blink::WebDevToolsAgentImpl::DispatchOnInspectorBackend() #15 0x7fbb906e5466 content::DevToolsAgent::OnDispatchOnInspectorBackend() ... We should figure out what's going on here.
,
Sep 21 2017
,
Oct 3 2017
,
Oct 3 2017
https://chromium-review.googlesource.com/#/c/chromium/src/+/697191 this patch fixes the crash for the tests. 5 tests ran as expected 4 tests failed with text diff
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf967918e6fda42e92613544742d27d69b88c05 commit cbf967918e6fda42e92613544742d27d69b88c05 Author: Suneel Kota <suneel.kota@samsung.com> Date: Wed Oct 04 10:26:36 2017 [RLS] Use correct ScrollableArea in InspectorLayerTreeAgent Scrolling Layer will be present in PLSA when RLS is enabled TEST=http/tests/devtools/layers no longer crashes Bug: 766497 Change-Id: Ie893969b482266f4da01e6171c1daf2a9b3386a2 Reviewed-on: https://chromium-review.googlesource.com/697191 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506356} [modify] https://crrev.com/cbf967918e6fda42e92613544742d27d69b88c05/AUTHORS [modify] https://crrev.com/cbf967918e6fda42e92613544742d27d69b88c05/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
,
Oct 4 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jmukthavaram@chromium.org
, Sep 20 2017