Pointercancel not fired on kevin when using stylus |
||||||||
Issue descriptionUse ToT Load: http://jsbin.com/bogasefeyo/edit?html,js,output Pointercancel is not dispatched when scrolling starts when using the stylus.
,
Sep 25 2017
ifdefs are okay as a short term fix. In any case, we should really focus on a longer-term fix: implement & ship InputDeviceCapabilities.pointerMovementScrolls, and use it as the condition here. http://wicg.github.io/InputDeviceCapabilities/#dom-uievent-sourcecapabilities
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca109349f4522f52aaf6b87e726ccf767a2f39d0 commit ca109349f4522f52aaf6b87e726ccf767a2f39d0 Author: Navid Zolghadr <nzolghadr@chromium.org> Date: Wed Oct 04 03:35:21 2017 Send pointercancel based on scroll capability of pointers Store whether a pointer is capable of scrolling in PointerEventManager (based on whether it is coming from touch path or not). Then when scroll happens send pointercancel for all scroll capable pointers instead of only touch pointers. Bug: 766486 Change-Id: I7ae6808fe3c976fcb2dd3d123f22e870011476ab Reviewed-on: https://chromium-review.googlesource.com/695841 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#506292} [modify] https://crrev.com/ca109349f4522f52aaf6b87e726ccf767a2f39d0/third_party/WebKit/Source/core/events/PointerEventFactory.cpp [modify] https://crrev.com/ca109349f4522f52aaf6b87e726ccf767a2f39d0/third_party/WebKit/Source/core/events/PointerEventFactory.h [modify] https://crrev.com/ca109349f4522f52aaf6b87e726ccf767a2f39d0/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp [modify] https://crrev.com/ca109349f4522f52aaf6b87e726ccf767a2f39d0/third_party/WebKit/Source/core/input/PointerEventManager.cpp
,
Oct 4 2017
,
Oct 5 2017
,
Oct 5 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5 2017
abdulsyed@ bhthompson@ can you take a look at this? The change's been in the master for about 2 days and I also tested it with the Canary build that came out today.
,
Oct 5 2017
,
Oct 5 2017
Thanks for the fix - can you please help explain what the fix is, is it truly critical for M62, or can it wait until 63?
,
Oct 5 2017
As far as I can tell it it critical for 62. Tom can elaborate on it more from Chrome OS side. But from Windows side we had some fixes regarding the drag/scrolling/selection behavior of pens on Windows and without this fix they are not complete. Basically what this fix does it to correctly send javascript events when browser starts consuming the event stream say for scrolling by pen. Without this fix, a page would not have a way of finding about the fact that the event stream is cut by the browser.
,
Oct 5 2017
If Abdul is good with it, I am good with it.
,
Oct 6 2017
Great thanks for confirming approving merge to M62. Based on comment 10, approving merge to M62. Branch:3202
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a11800062c65e2e1d305ab18402c48a3833dd9eb commit a11800062c65e2e1d305ab18402c48a3833dd9eb Author: Navid Zolghadr <nzolghadr@chromium.org> Date: Fri Oct 06 17:03:44 2017 Send pointercancel based on scroll capability of pointers Store whether a pointer is capable of scrolling in PointerEventManager (based on whether it is coming from touch path or not). Then when scroll happens send pointercancel for all scroll capable pointers instead of only touch pointers. Bug: 766486 Change-Id: I7ae6808fe3c976fcb2dd3d123f22e870011476ab Reviewed-on: https://chromium-review.googlesource.com/695841 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#506292}(cherry picked from commit ca109349f4522f52aaf6b87e726ccf767a2f39d0) Reviewed-on: https://chromium-review.googlesource.com/705314 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#607} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a11800062c65e2e1d305ab18402c48a3833dd9eb/third_party/WebKit/Source/core/events/PointerEventFactory.cpp [modify] https://crrev.com/a11800062c65e2e1d305ab18402c48a3833dd9eb/third_party/WebKit/Source/core/events/PointerEventFactory.h [modify] https://crrev.com/a11800062c65e2e1d305ab18402c48a3833dd9eb/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp [modify] https://crrev.com/a11800062c65e2e1d305ab18402c48a3833dd9eb/third_party/WebKit/Source/core/input/PointerEventManager.cpp |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dtapu...@chromium.org
, Sep 25 2017