Tapping the fake omnibox on iPad does not make the content scroll up |
||||||||
Issue descriptioniPad only What steps will reproduce the problem? (1) Open NTP with ContentSuggestions enabled (2) Disable the suggestions in settings -> Privacy -> Search and Sites suggestions (3) Tap the fake omnibox What is the expected result? The collection should be scrolled up, the fake omnibox going below the real omnibox. What happens instead? The collection scroll half way, corresponding to the height of the collection. Video: https://drive.google.com/open?id=0B21N-0pPGAuJdFRTaVlRZEFnVE0
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf commit 1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 20 07:45:09 2017 NTP on iPad can be scrolled up to the fake omnibox The height of the ContentSuggestions collection on NTP iPad is not sufficient to allow the fake omnibox to be scrolled enough to be hidden by the real toolbar. This is particularly a problem when the omnibox is focused because the collection is only half scrolled if the content is not high enough. Bug: 766483 Change-Id: I00c2b6f7446e801dec56e19af28d139da42b8b1a Reviewed-on: https://chromium-review.googlesource.com/671354 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#503080} [modify] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.h [modify] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [add] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.h [add] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.mm [modify] https://crrev.com/1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Sep 20 2017
,
Sep 20 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 20 2017
Merge request
,
Sep 20 2017
This bug requires manual review: Less than 23 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2017
Verified in Build - 63.0.3220.3 Canary- iPad mini iOS 11, iPhone 6 iOS 11 The issue “Tapping the fake omnibox on iPad does not make the content scroll up” has been Verified now for the fix.
,
Sep 21 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380 commit 8b06611aaf15bbf5fe19f99cb2e3c394fec3c380 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 22 07:53:41 2017 NTP on iPad can be scrolled up to the fake omnibox The height of the ContentSuggestions collection on NTP iPad is not sufficient to allow the fake omnibox to be scrolled enough to be hidden by the real toolbar. This is particularly a problem when the omnibox is focused because the collection is only half scrolled if the content is not high enough. Bug: 766483 Change-Id: I00c2b6f7446e801dec56e19af28d139da42b8b1a Reviewed-on: https://chromium-review.googlesource.com/671354 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503080}(cherry picked from commit 1a833e0ec4edb771ff87c4cd98625eb8b1e1d9bf) Reviewed-on: https://chromium-review.googlesource.com/678674 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#393} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.h [modify] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm [add] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.h [add] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout_handset.mm [modify] https://crrev.com/8b06611aaf15bbf5fe19f99cb2e3c394fec3c380/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Sep 27 2017
Devices: iPad Air iOS: 10.3.3, 11.0 Build: 62.0.3202.35 beta Verified following the steps mentioned in comment #0, fake omnibox is scrolled up with most popular icons properly aligned and the fake omnibox moving animation is good. Looks good. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gambard@chromium.org
, Sep 19 2017