Issue metadata
Sign in to add a comment
|
Update fetch-event-redirect.https.html |
||||||||||||||||||||||
Issue descriptionWhile I'm trying to support redirect for sub-resource loading with S13nServiceWorker ( issue 764224 ), I found that some expectations in fetch-event-redirect.https.html in WPT are outdated. We should allow responding to non-navigation requests which redirect mode is 'manual' with opaque-redirect responses. I implemented it in https://codereview.chromium.org/2526343003. But the test has "should_reject: true" for those test cases.
,
Sep 19 2017
And also, the test is using the URLs with embedded credentials (e.g. `https://user:pass@host/`) which are blocked now. https://www.chromestatus.com/feature/5669008342777856
,
Oct 12 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e24581c71313e17a478a9ecb05583334c96d09f3 commit e24581c71313e17a478a9ecb05583334c96d09f3 Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Oct 12 09:49:57 2017 Revise fetch-event-redirect.https.html This CL revises the test: - Use the same service worker for each tests. - Call fetch() in iframe using frame.contentWindow.fetch(). - Remove unused expected_ properties when should_reject is true. - Fix should_reject for 'manual' redirect mode tests. Some tests are failing. It is because Chromium blocks credentialsed subresources. See: https://www.chromestatus.com/feature/5669008342777856 Bug: 766476 Change-Id: I4f328a6c3bed11a0604a5aa9ea08b1068b83ad3c Reviewed-on: https://chromium-review.googlesource.com/714976 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#508290} [modify] https://crrev.com/e24581c71313e17a478a9ecb05583334c96d09f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-redirect.https-expected.txt [modify] https://crrev.com/e24581c71313e17a478a9ecb05583334c96d09f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [delete] https://crrev.com/68e830a0e34fe94ea30221c1441294608c1ee95c/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-event-redirect-iframe.html
,
Oct 12 2017
Thanks for fixing the test! We implemented the 'manual' redirect mode for non-navigations a while ago, but I missed correcting the test code here. I see we are currently rejecting the promise in those cases due to a bug in the test that you have fixed.
,
Oct 17 2017
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by horo@chromium.org
, Sep 19 2017