New issue
Advanced search Search tips

Issue 766446 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Removal of EWTestHelper variants just tweaking the behavior of EventDispatcher

Project Member Reported by shimazu@chromium.org, Sep 19 2017

Issue description

Currently we have two ways to change the behavior of event handling when unit testing:
1: Implementing MockEventDispatcher
2: Overriding EmbeddedWorkerTestHelper (e.g. OnFetchEvent)

Method 2 has been used when we used the legacy IPC for event dispatching, but it's no longer needed. 
The benefit of method 1 is we can decompose logics into small chunks (it's very clear to understand MockEventDispatcher only cares the renderer's behavior related to Mojo messages) compared to overriding EWTestHelper.
For simplicity, I think it's better to unify them into method 1. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: shimazu@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
I guess shimazu@ is still interested in this.

Sign in to add a comment