New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

emerge-kahlee chromeos-kernel-4_12 fails to install due to firmware conflict

Project Member Reported by djkurtz@chromium.org, Sep 19 2017

Issue description

# Cherry-pick these 3 CLs:

https://chromium-review.googlesource.com/#/c/chromiumos/manifest/+/657958/
https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/656218/
https://chromium-review.googlesource.com/#/c/chromiumos/overlays/board-overlays/+/672008

# repo sync

$ emerge-kahlee chromeos-kernel-4_12

Fails during

>>> Installing (1 of 1) sys-kernel/chromeos-kernel-4_12-9999::chromiumos to /build/kahlee/
...
 * Using kernel config: chromeos-amd-stoneyridge
 *    - enabling Turn off ACPI AC config
 *    - disabling framebuffer console config
 *    - enabling CDC MBIM driver config
 *    - enabling PC serial config
 *    - enabling TPM support config
 *    - enabling Transparent Hugepage Support config
 *    - enabling 802.1Q VLAN config
 *    - disabling VT console config
 *    - Embedding Firmware for AMD GPU firmware
 * This package will overwrite one or more files that may belong to other
 * packages (see list below). You can use a command such as `portageq ...
 * 
 * Detected file collision(s):
 * 
 *      /build/kahlee/lib/firmware/radeon/RV710_me.bin
 *      /build/kahlee/lib/firmware/radeon/RS780_me.bin
 *      /build/kahlee/lib/firmware/radeon/RS600_cp.bin
 *      /build/kahlee/lib/firmware/radeon/R300_cp.bin
 *      /build/kahlee/lib/firmware/radeon/RV630_pfp.bin
 *      /build/kahlee/lib/firmware/radeon/R200_cp.bin
 *      /build/kahlee/lib/firmware/radeon/RV770_me.bin
 *      /build/kahlee/lib/firmware/radeon/RV730_me.bin
 *      /build/kahlee/lib/firmware/radeon/R520_cp.bin
 *      /build/kahlee/lib/firmware/radeon/RV620_pfp.bin
 *      /build/kahlee/lib/firmware/radeon/RV770_pfp.bin
 *      /build/kahlee/lib/firmware/radeon/RV630_me.bin

These firmware files are already installed by sys-kernel/linux-firmware.
 
groeck pointed out that chromeos-4.12 is missing this CL, which hacked around this issue on chromeos-4.4:

https://chromium-review.googlesource.com/322338
0c4e333d1895c57ad7f688ef5520e39a3e8938e3
CHROMIUM: firmware: do not install radeon firmware
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017

Labels: merge-merged-chromeos-4.12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3b3e7875b20311c62a4cc24203edd64c690aa818

commit 3b3e7875b20311c62a4cc24203edd64c690aa818
Author: Dominik Behr <dbehr@chromium.org>
Date: Tue Sep 19 04:24:31 2017

CHROMIUM: firmware: do not install radeon firmware

it has been superceeded by linux-firmware package

BUG=chromium:338504, chromium:766443 
TEST=build and install amd64generic kernel, it should not install
anything to /lib/firmware/radeon
TEST=./build_packages --board=kahlee
 => builds clean w/ chromeos-kernel-4_12

(Change-Id: Ia8fed3f39f75fa480d27baa77ab82e99d4ea99be)
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/184962
Reviewed-by: Olof Johansson <olofj@chromium.org>
(cherry picked from commit 2f3538b5c89db87fe979cb06b1480ae311862304)
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

(Change-Id: I90d9ed8dc71977e9d132e236f2b1fe73e7c24394)
Reviewed-on: https://chromium-review.googlesource.com/322338
Commit-Ready: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 0c4e333d1895c57ad7f688ef5520e39a3e8938e3)
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

Change-Id: I286a7333179f08595c932708dd269635fd44106e
Reviewed-on: https://chromium-review.googlesource.com/672009
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Commit-Queue: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/3b3e7875b20311c62a4cc24203edd64c690aa818/firmware/Makefile

Comment 3 by vapier@chromium.org, Sep 19 2017

really wish we'd move away from installing any firmware from the kernel repos.  it's what the linux-firmware repo & ebuild are for.

Comment 4 by groeck@google.com, Sep 19 2017

#3: We are; firmware is gone from the kernel in v4.14. Question here was if we should backport the relevant changes to chromeos-4.12 or go with the previous hack. Since chromeos-4.12 won't ship and will be replaced with chromeos-4.14, it does not really matter, and going with the hack seemed to be less risky at this point.

Comment 5 by groeck@chromium.org, Sep 19 2017

Status: Fixed (was: Assigned)

Comment 6 by vapier@chromium.org, Sep 22 2017

*my hero* ->  issue 767586 

Comment 7 by groeck@chromium.org, Sep 22 2017

Yes, reverting the fix applied here and applying the upstream patches will be the next step.

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment