Remove suggestion apps, expand arrow and all apps indicator from apps grid view when it is inside folder |
|||||
Issue descriptionCurrent apps grid view in app list folder view has suggestion apps, expand arrow and all apps indicator as child view [1], but does not layout them in Layout() [2]. We need to prevent these views from being parented by apps grid view in the first place. [1] https://cs.chromium.org/chromium/src/ui/app_list/views/apps_grid_view.cc?l=317 [2] https://cs.chromium.org/chromium/src/ui/app_list/views/apps_grid_view.cc?l=855
,
Sep 19 2017
,
Sep 19 2017
claudiomdsjr@, feel free to take it, thanks!
,
Sep 19 2017
I have a CL: https://chromium-review.googlesource.com/c/chromium/src/+/671130 under review, but it will not fix the focus movement within folder view which is already broken before the CL.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6ff8e706cc0344dd11a99b436e850de3c1c81bc commit f6ff8e706cc0344dd11a99b436e850de3c1c81bc Author: Weidong Guo <weidongg@chromium.org> Date: Wed Sep 20 20:35:14 2017 cros: Prevent suggestion apps from being created in AppsGridView if it's in folder view Changes: Set AppsGridViewFolderDelegate in AppsGridView's constructor to prevent Suggestion apps, expand arrow and all apps indicator from being created in the first place. BUG= 766439 Change-Id: Ib4c1f39c16ae490f1f9fd4486ca81046058ff79a Reviewed-on: https://chromium-review.googlesource.com/671130 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#503237} [modify] https://crrev.com/f6ff8e706cc0344dd11a99b436e850de3c1c81bc/ui/app_list/views/app_list_folder_view.cc [modify] https://crrev.com/f6ff8e706cc0344dd11a99b436e850de3c1c81bc/ui/app_list/views/apps_container_view.cc [modify] https://crrev.com/f6ff8e706cc0344dd11a99b436e850de3c1c81bc/ui/app_list/views/apps_grid_view.cc [modify] https://crrev.com/f6ff8e706cc0344dd11a99b436e850de3c1c81bc/ui/app_list/views/apps_grid_view.h
,
Sep 28 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by claudiom...@gmail.com
, Sep 19 2017