New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 761138



Sign in to add a comment

Replace vector<Extent> with RepeatedPtrField<Extent> in payload_consumer

Project Member Reported by ahass...@chromium.org, Sep 19 2017

Issue description

Extent is a protobuf and it is better to use RepeatedPtrField in order to avoid unnecessary data copies.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/cd7edbe3eeff0b4379649eea8308c325882407ff

commit cd7edbe3eeff0b4379649eea8308c325882407ff
Author: Amin Hassani <ahassani@google.com>
Date: Thu Sep 21 21:15:50 2017

update_engine: Replace vector<Extent> with RepeatedPtrField<Extent>

This patch removes references to vector<Extent> and replaces them with
RepeatedPtrField in payload_consumer. Extent itself is a protobuf item
and it makes sense to use google::protobuf::RepeatedPtrField instead of
vector because then we won't have any extra copy to vector. We can
directly use the list of extents given in the payload protobuf.

Also removed references to vector in files which did not use vector.

BUG= chromium:766397 
TEST=FEATURES="test" emerge-amd64-generic update_engine

Change-Id: I1f12332ff4d6303c1e4b7470bb87bf934acdf81a
Reviewed-on: https://chromium-review.googlesource.com/672006
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/xz_extent_writer.h
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/payload_verifier.h
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/extent_writer_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/download_action.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/fake_extent_writer.h
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/bzip_extent_writer.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/bzip_extent_writer.h
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/mtd_file_descriptor.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_generator/zip_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/file_descriptor_utils.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/extent_writer.h
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/xz_extent_writer_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/extent_writer.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/bzip_extent_writer_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/file_writer_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/delta_performer.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/postinstall_runner_action_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/xz_extent_writer.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/download_action_unittest.cc
[modify] https://crrev.com/cd7edbe3eeff0b4379649eea8308c325882407ff/payload_consumer/file_descriptor_utils.h

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment