New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766391 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update MemorySanitizer (MSan) documentation

Project Member Reported by msw@chromium.org, Sep 18 2017

Issue description

Update MemorySanitizer (MSan) documentation

I found a couple potential issues with the msan documentation:
https://www.chromium.org/developers/testing/memorysanitizer

1) I had an unexpected test crash, possibly related to outdated recommended gn args:
(my crash might have also been from skipping the GYP_DEFINES step at first)

Recommended:
 is_msan = true
 use_prebuilt_instrumented_libraries = true
 is_debug = false  # Release build.
 enable_nacl = false  # Necessary until the NaCl GN build is more complete.

Linux_MSan_Builder/Linux_ChromiumOS_MSan_Builder (non-trivial differences):
 +is_component_build = false
 +msan_track_origins = 2
 +strip_absolute_paths_from_debug_symbols = true
 -enable_nacl = false

2) The docs say to "Run the resulting binaries as usual. Pipe the output through tools/valgrind/asan/asan_symbolize.py to get symbolized reports. If running the "chrome" target pipe stderr and stdout."

That didn't work for me when running a browser_tests fixture. Running "out/Default/browser_tests --gtest_filter=DemoAppLauncherTest.Basic | tools/valgrind/asan/asan_symbolize.py" with my crash from https://crrev.com/502376 didn't  symbolize the stack. I had to copy the stack to a separate file (crash.txt) and pipe that via "cat crash.txt | tools/valgrind/asan/asan_symbolize.py"... Is that expected? (update docs if so, split out a bug if not?)
 
Cc: glider@chromium.org kcc@chromium.org
Probably also need to update the list of folks to contact...

Comment 2 by glider@chromium.org, Sep 19 2017

Cc: euge...@chromium.org
Guess eugenis@ is the primary point of contact for MSan now.

Comment 3 by msw@chromium.org, Sep 19 2017

Adding a tools/msan/OWNERS and README.md (to replace the chromium.org page?) might be good!
Components: -Internals>Instrumentation>Memory Tools>Stability
Dropping Internals>Instrumentation>Memory as that is about counting memory bytes and not sanitizers.

Status: Fixed (was: Untriaged)
I've updated the docs to address some of your comments:
 * enable_nacl is no longer necessary
 * msan_track_origins = 2 is the default setting, can be removed from the bot recipe
 * changed contact address to mine

2) I'm not sure why the docs said stderr must be piped only for the "chrome" target. MSan reports are always printed to stderr. It's easiest to send output to the script with "|&".


Sign in to add a comment