ARC++ apps cannot use Instant Tethering connection |
|||||||||
Issue descriptionPorted from https://buganizer.corp.google.com/issues/65633915. Looks like what we need to do is pass the underlying Wi-Fi network's Shill path in ArcNetHostImpl::DefaultNetworkChanged() if a tether network is the default network.
,
Sep 20 2017
I see there's a pending change. https://chromium-review.googlesource.com/c/chromium/src/+/671670 nice!
,
Sep 20 2017
,
Sep 20 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 20 2017
Approving merge to M61 and M62. Please merge and validate on M62 before merging to M61.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f42fd961827e948d3eac23eaf4a5f50a04292512 commit f42fd961827e948d3eac23eaf4a5f50a04292512 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Sep 20 05:59:11 2017 [CrOS Tether] Fix bug which prevented ARC++ from using Tether networks. The issue was that ARC++ was relying on the default network's Shill path in order to connect. However, Tether networks are not recognized by Shill and actually delegate to an underlying Wi-Fi connection. The fix is to use the underlying Wi-Fi network's Shill path whenever a Tether network is connected. Bug: 766388 , 672263 Change-Id: I3ac534a16884bb64bfea65ce4d20229c1c2f8209 Reviewed-on: https://chromium-review.googlesource.com/671670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#503064} [modify] https://crrev.com/f42fd961827e948d3eac23eaf4a5f50a04292512/components/arc/net/arc_net_host_impl.cc
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e8d818a54379a926be51f30ad4896e2eec92700 commit 6e8d818a54379a926be51f30ad4896e2eec92700 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Sep 20 06:05:54 2017 [CrOS Tether] Fix bug which prevented ARC++ from using Tether networks. The issue was that ARC++ was relying on the default network's Shill path in order to connect. However, Tether networks are not recognized by Shill and actually delegate to an underlying Wi-Fi connection. The fix is to use the underlying Wi-Fi network's Shill path whenever a Tether network is connected. TBR=khorimoto@google.com (cherry picked from commit f42fd961827e948d3eac23eaf4a5f50a04292512) Bug: 766388 , 672263 Change-Id: I3ac534a16884bb64bfea65ce4d20229c1c2f8209 Reviewed-on: https://chromium-review.googlesource.com/671670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503064} Reviewed-on: https://chromium-review.googlesource.com/674387 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#349} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/6e8d818a54379a926be51f30ad4896e2eec92700/components/arc/net/arc_net_host_impl.cc
,
Sep 20 2017
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d3f0860310e3a692c28f22098dfb9dfc5b969a4 commit 2d3f0860310e3a692c28f22098dfb9dfc5b969a4 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Sep 20 06:09:07 2017 [CrOS Tether] Fix bug which prevented ARC++ from using Tether networks. The issue was that ARC++ was relying on the default network's Shill path in order to connect. However, Tether networks are not recognized by Shill and actually delegate to an underlying Wi-Fi connection. The fix is to use the underlying Wi-Fi network's Shill path whenever a Tether network is connected. TBR=khorimoto@google.com (cherry picked from commit f42fd961827e948d3eac23eaf4a5f50a04292512) Bug: 766388 , 672263 Change-Id: I3ac534a16884bb64bfea65ce4d20229c1c2f8209 Reviewed-on: https://chromium-review.googlesource.com/671670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503064} Reviewed-on: https://chromium-review.googlesource.com/674745 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1245} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2d3f0860310e3a692c28f22098dfb9dfc5b969a4/components/arc/net/arc_net_host_impl.cc
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by zelidrag@chromium.org
, Sep 19 2017