New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766385 link

Starred by 2 users
Status: Duplicate
Owner:
dgozman@chromium.org
Closed: Sep 2017
Cc:
pwang@chromium.org
gurcheta...@chromium.org
█ marc...@chromium.org
pfeldman@chromium.org
ihf@chromium.org
█ dbehr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

zero-to-nonzero regression in graphics_Stress/Failures_tabopenclose on cros-elm at 32120000994200001:32160000994500000

Project Member Reported by gurcheta...@chromium.org, Sep 18 2017 
Performance dashboard identified a zero-to-nonzero regression in graphics_Stress/Failures_tabopenclose on cros-elm at revision range 32120000994200001:32160000994500000. Graph: https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-elm&tests=graphics_Stress%2FFailures_tabopenclose&checked=Failures_tabopenclose%2CFailures_tabopenclose_ref%2Cref&rev=32160000994500000


ChromeOS Version range: 63.9937.0.0 - 63.9945.0.0 
Chrome Version range: 63.0.3212.0 - 63.0.3216.0

Comment 1 by gurcheta...@chromium.org, Sep 20 2017

Cc: pfeldman@chromium.org
Owner: dgozman@chromium.org
[bisected]

05273a8ee434a38484b8a8e04d04d0a4c79d51d7 is the first bad commit
commit 05273a8ee434a38484b8a8e04d04d0a4c79d51d7
Author: Dmitry Gozman <dgozman@chromium.org>
Date:   Tue Sep 12 21:48:15 2017 +0000

    [DevTools] Mark targets as 'page' by default in ChromeDevToolsManagerDelegate
    
    Currently we mark targets as 'other' based on WebContents being present
    in TabStripModel, which is timing-dependent. This patch marks everything
    not quialified for other types as 'page', making target type consistent.
    
    Bug:  759783 
    Change-Id: I0b26ee12474b004121e3e0083d67eb809b4eba11
    Reviewed-on: https://chromium-review.googlesource.com/639024
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#501410}

dgozman@, pfeldman@ -- can you investigate why it's harder to open and close tabs with this CL?  To build ChomeOS, please follow this guide:

http://www.chromium.org/chromium-os/developer-guide

After you've built you can run this test with the following command:

test_that -b ${BOARD} $IP graphics_Stress.tabopenclose

The test is unable to open and close as many tabs as it usually does.  The error we're getting is:

Timed out while waiting 5s for py_utils.WaitFor(lambda: tab_id not in self.IterContextIds(), timeout=5)

Let me know if you have any questions.

Comment 2 by gurcheta...@chromium.org, Sep 20 2017

Cc: gurcheta...@chromium.org

Comment 3 by ihf@chromium.org, Sep 25 2017

Cc: dbehr@chromium.org
Sounds like Chrome crashed? Are we leaking resources?

Comment 5 by ihf@chromium.org, Sep 28 2017

Mergedinto: 763834
Status: Duplicate (was: Verified)
►

Sign in to add a comment