New issue
Advanced search Search tips

Issue 766382 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

Clean Up TemplateURLService Handling (when to check for non-nulls)

Project Member Reported by mpear...@chromium.org, Sep 18 2017 

See pkasting@'s message here, and my reply (which to be fair only answers some of this comments).
https://chromium-review.googlesource.com/c/chromium/src/+/664251#message-a0da1febbe62c055b5f2915c4b7cec444623c9bc
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874c50528a8520f3c4990d3a464bc172588ada9d

commit 874c50528a8520f3c4990d3a464bc172588ada9d
Author: Kevin Bailey <krb@chromium.org>
Date: Thu Nov 16 21:04:54 2017

[omnibox] Reworked checking if template URL service is null

Moved resolution of template URL service earlier, as well as DCHECKs.
Removed subsequent unnecessary null tests.

Bug:  766382 
Change-Id: I7ee5460e8a02bf28dc5984d5424f5ab7c826896f
Reviewed-on: https://chromium-review.googlesource.com/772071
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517188}
[modify] https://crrev.com/874c50528a8520f3c4990d3a464bc172588ada9d/chrome/browser/autocomplete/keyword_extensions_delegate_impl.cc
[modify] https://crrev.com/874c50528a8520f3c4990d3a464bc172588ada9d/components/omnibox/browser/keyword_provider.cc
[modify] https://crrev.com/874c50528a8520f3c4990d3a464bc172588ada9d/components/omnibox/browser/keyword_provider.h

Comment 2 by k...@chromium.org, Nov 16 2017

Status: Fixed (was: Available)
►

Sign in to add a comment