New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766381 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

[Culprit-Finder] Remove all '/' at the end of dependency path.

Project Member Reported by kateso...@chromium.org, Sep 18 2017

Issue description

Note that for dependencies in DEPS of chromium repo, there is no '/' at the end of dependency path.
https://chromium.googlesource.com/chromium/src/+/master/DEPS

So, we should make the same assumption and remove all '/' at the end of dependency paths.
 
Blocking: 765834
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/61bac601ca220ea5f4c2b81a18c02bcabb381574

commit 61bac601ca220ea5f4c2b81a18c02bcabb381574
Author: Sharu Jiang <katesonia@google.com>
Date: Tue Sep 19 03:22:28 2017

[Culprit-Finder] Remove all '/' at the end of dependency path.

Note that for dependencies in DEPS of chromium repo, there is no '/' at the end of dependency path.
https://chromium.googlesource.com/chromium/src/+/master/DEPS

So, we should make the same assumption and remove all '/' at the end of dependency paths.

Bug:  766381 
Change-Id: Ib9d889595bf69c648bd77de7d534fe644754ca19
Reviewed-on: https://chromium-review.googlesource.com/671963
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/predator/analysis/test/parse_util_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/services/build_failure_analysis.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/libs/deps/chrome_dependency_fetcher.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/services/deps.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/predator/analysis/test/stacktrace_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/services/test/build_failure_analysis_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/predator/analysis/test/uma_sampling_profiler_data_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/libs/deps/test/chrome_dependency_fetcher_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/findit/services/test/deps_test.py
[modify] https://crrev.com/61bac601ca220ea5f4c2b81a18c02bcabb381574/appengine/predator/analysis/parse_util.py

Status: Fixed (was: Assigned)
Cc: kateso...@chromium.org
 Issue 765835  has been merged into this issue.

Sign in to add a comment