New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766374 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

misleading usage of GerritPatch and GerritPatchTuple

Project Member Reported by nxia@chromium.org, Sep 18 2017

Issue description

we have GerritPatch and GerritPatchTuple classes, sometimes they're used in mix and the docstring doesn't document it correctly. The method below documents both classes, but most methods in clactions only specifies GerritPatch. Probably should refactor the two classes using some inheritance strategies.


  def MarkForgiven(self, change, reason=None):
    """Mark |change| as forgiven with |reason|.

    Args:
      change: A GerritPatch or GerritPatchTuple object.
 
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build
Labels: -Pri-2 Pri-3

Comment 2 by nxia@chromium.org, May 18 2018

Components: -Infra>Client>ChromeOS>Build Infra>Client>ChromeOS>CI
Status: WontFix (was: Untriaged)

Sign in to add a comment