misleading usage of GerritPatch and GerritPatchTuple |
||
Issue description
we have GerritPatch and GerritPatchTuple classes, sometimes they're used in mix and the docstring doesn't document it correctly. The method below documents both classes, but most methods in clactions only specifies GerritPatch. Probably should refactor the two classes using some inheritance strategies.
def MarkForgiven(self, change, reason=None):
"""Mark |change| as forgiven with |reason|.
Args:
change: A GerritPatch or GerritPatchTuple object.
,
May 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ayatane@chromium.org
, May 17 2018Labels: -Pri-2 Pri-3