[Chrome Home] Remove padding from omnibox results container |
||||||||
Issue descriptionPer implementation review, we should remove some of the padding from the omnibox results container (below the omnibox above the suggestions). Assigning to hannah to clarify exactly what the padding should be.
,
Sep 22 2017
Programatically we define the space between the bottom of the toolbar and suggestions, rather than between the omnibox and suggestions (as the red-lines show). This is what the elements look like programatically: ____________________________________ | | } | ( url bar ) [ ] : | }--> toolbar |____________________________________| } | | | SUGGESTIONS | The current toolbar height is 56dp, rather than the 64dp (?) it will be once we implement adding extra space. I wouldn't expect the toolbar height to affect the padding above suggestions, but maybe it does? It'd be helpful if the mocks had the entire toolbar as a selectable unit.
,
Sep 22 2017
,
Sep 25 2017
Your askii wireframe is #amaze I've attached redlines for the toolbar (with the added space on top / 64dp header). But regardless of header size, both basically use 0dp padding above the suggestion row just for the omnibox focused state since the grey omnibox is shorter/has no drop shadow that requires space.
,
Sep 26 2017
Thanks Hannah! This is currently scoped for M64, is that correct? Daniel, will you please take a look at this?
,
Sep 26 2017
ack.
,
Sep 27 2017
I was under the impression it was for M63 (Was feedback from implementation review for M62)- do you think this can make it in?
,
Sep 27 2017
+ktam@ for scoping refinement This should be pretty easy if we want to pull it into 63.
,
Sep 29 2017
Sure let's move into 63 if it's not too bad. I've been noticing this as well.
,
Sep 29 2017
huayinz@, will you please look at this for 63?
,
Oct 2 2017
Screenshot
,
Oct 2 2017
Perfect! Thanks so much for getting this change in last minute!!!! Really appreciate it :)
,
Oct 2 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6dbdeb236c356fdf1b4af6f3cea1f517b6ffcbd commit b6dbdeb236c356fdf1b4af6f3cea1f517b6ffcbd Author: Becky Zhou <huayinz@chromium.org> Date: Tue Oct 03 17:30:12 2017 [Chrome Home] Remove top padding from omnibox suggestions list Bug: 766369 Change-Id: I322e6ca1ce8e609753d08cf48a29f7324bd36bd1 Reviewed-on: https://chromium-review.googlesource.com/695802 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#506087} [modify] https://crrev.com/b6dbdeb236c356fdf1b4af6f3cea1f517b6ffcbd/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
,
Oct 3 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hannahs@chromium.org
, Sep 22 2017