clean -Werror,-Wtautological-unsigned-zero-compare error |
||
Issue descriptionNew llvm-next failed to build some packages because of the warning -Werror,-Wtautological-unsigned-zero-compare We need to clean that.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/074d01a7329b138fa04b408bdd821509fd56eb2a commit 074d01a7329b138fa04b408bdd821509fd56eb2a Author: Yunlian Jiang <yunlian@google.com> Date: Wed Sep 20 23:37:59 2017 crash: fix -Wtautological-unsigned-zero-compare warning. This fixes the warning crash-reporter/user_collector_base.cc:189:36: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-zero-compare] if (ids.size() != kIdMax || kind < 0 || kind >= kIdMax) { ~~~~ ^ ~ BUG= chromium:766345 TEST=The warning is gone. Change-Id: Id911d47dad14287b47c91aec28f8f8487465778a Reviewed-on: https://chromium-review.googlesource.com/671853 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/074d01a7329b138fa04b408bdd821509fd56eb2a/crash-reporter/user_collector_base.h
,
Sep 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7cdc7fa217522a543d184cee019139275ad68a9 commit d7cdc7fa217522a543d184cee019139275ad68a9 Author: Yunlian Jiang <yunlian@google.com> Date: Sat Sep 23 05:25:35 2017 glmark2: diasble tautological-unsigned-zero-compare warning. This silences some -Wtautological-unsigned-zero-compare warning triggered in new llvm-next. ../src/libmatrix/shader-source.cc:424:18: error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-zero-compare] else if (val >= 0 && val < ShaderSource::PrecisionValueDefault) { ~~~ ^ ~ ../src/libmatrix/shader-source.cc:515:14: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-zero-compare] if (type < 0 || type > ShaderSource::ShaderTypeUnknown) ~~~~ ^ ~ ../src/libmatrix/shader-source.cc:540:14: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-zero-compare] if (type < 0 || type > ShaderSource::ShaderTypeUnknown) ~~~~ ^ ~ 3 errors generated. BUG= chromium:766345 TEST=The warnnig is gone. Change-Id: I87239c805101836ba56d7fd3e541e41c8f30e93b Reviewed-on: https://chromium-review.googlesource.com/671473 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [rename] https://crrev.com/d7cdc7fa217522a543d184cee019139275ad68a9/app-benchmarks/glmark2/glmark2-285-r12.ebuild [modify] https://crrev.com/d7cdc7fa217522a543d184cee019139275ad68a9/app-benchmarks/glmark2/glmark2-285.ebuild
,
Sep 28 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/vendor/dlm/+/919621f8ac24b522079a8d67f4d1e8bc0a92d6b7 commit 919621f8ac24b522079a8d67f4d1e8bc0a92d6b7 Author: Yunlian Jiang <yunlian@google.com> Date: Thu Sep 28 04:13:00 2017
,
Oct 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 19 2017