Rules panic when auditing c1dd5bd181b2f3ff26bba13ffabc357de7bc9a9f |
||
Issue descriptionThe commit in question is a revert made by findit in august, this commit should fail the audit because the link to the failed build is in a deprecated format (wrong prefix) Instead, the rules panic, which is only appropriate when a rule cannot determine whether there is a violation or not. In this case, the rule should fail as not having a correct link to a failed build would clearly be a violation.
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/90ba80829cf8c0af975959cc2c57f2755e854081 commit 90ba80829cf8c0af975959cc2c57f2755e854081 Author: Roberto Carrillo <robertocn@google.com> Date: Tue Sep 19 00:16:19 2017 [cr-audit-commits] Fail when link to failed build is not present. Currently the rule to check the failed build panics if the link is not present. This is the wrong behavior, as clearly such commit does not comply with the policy. This change addresses such issue. R=chanli,stgao BUG= 766344 Change-Id: Ic826ac5b0921ea957528d47949ac8bec5f11f116 Reviewed-on: https://chromium-review.googlesource.com/671851 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/90ba80829cf8c0af975959cc2c57f2755e854081/go/src/infra/appengine/cr-audit-commits/app/utils.go [modify] https://crrev.com/90ba80829cf8c0af975959cc2c57f2755e854081/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go
,
Sep 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by robert...@chromium.org
, Sep 18 2017