Harmonize certificate selection dialog (CertificateSelector) [needs mock] |
||
Issue descriptionCouldn't find an existing bug for this one. I'm not sure how to invoke it without tests.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06aca52553654496df42735a1dffd7eb1d4b0546 commit 06aca52553654496df42735a1dffd7eb1d4b0546 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Sep 20 20:24:41 2017 Add BrowserDialogTest for CertificateSelector. Bug: 766343 Change-Id: Iea2edaadcfce61ba73a28342c65878804e10dd22 Reviewed-on: https://chromium-review.googlesource.com/661721 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#503234} [add] https://crrev.com/06aca52553654496df42735a1dffd7eb1d4b0546/chrome/browser/ui/views/certificate_selector_dialog_browsertest.cc [modify] https://crrev.com/06aca52553654496df42735a1dffd7eb1d4b0546/chrome/test/BUILD.gn
,
Jan 11 2018
The "Select certificate" image (mac_views_browser_select.png) needs the 'close-x removed. The rest LGTM. |
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Sep 20 201759.6 KB
59.6 KB View Download
75.8 KB
75.8 KB View Download
83.8 KB
83.8 KB View Download
77.0 KB
77.0 KB View Download