New issue
Advanced search Search tips

Issue 766343 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Harmonize certificate selection dialog (CertificateSelector) [needs mock]

Project Member Reported by bsep@chromium.org, Sep 18 2017

Issue description

Couldn't find an existing bug for this one. I'm not sure how to invoke it without tests.
 
cert.PNG
47.2 KB View Download

Comment 1 by tapted@chromium.org, Sep 20 2017

Labels: -OS-Mac
I configured my webserver to show this. Just visit http://go/tzyrp .

This is a native dialog on Mac, and should probably stay that way..

Currently, it is native with --secondary-ui-md on Mac, but mac_views_browser runs:
 - toolkit-views selector
 - native viewer

which is weird (and a bug - I've made  Issue 766926 ).

Windows currently does this too, but I don't think it has a native OS *selector* - just a native viewer, which is used.
cocoa_select.png
59.6 KB View Download
cocoa_select_view.png
75.8 KB View Download
mac_views_browser_select.png
83.8 KB View Download
mac_views_browser_select_view.png
77.0 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06aca52553654496df42735a1dffd7eb1d4b0546

commit 06aca52553654496df42735a1dffd7eb1d4b0546
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Sep 20 20:24:41 2017

Add BrowserDialogTest for CertificateSelector.

Bug: 766343
Change-Id: Iea2edaadcfce61ba73a28342c65878804e10dd22
Reviewed-on: https://chromium-review.googlesource.com/661721
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503234}
[add] https://crrev.com/06aca52553654496df42735a1dffd7eb1d4b0546/chrome/browser/ui/views/certificate_selector_dialog_browsertest.cc
[modify] https://crrev.com/06aca52553654496df42735a1dffd7eb1d4b0546/chrome/test/BUILD.gn

Comment 3 by bettes@chromium.org, Jan 11 2018

Owner: tapted@chromium.org
The "Select certificate" image (mac_views_browser_select.png) needs the 'close-x removed. The rest LGTM. 

Sign in to add a comment