New issue
Advanced search Search tips

Issue 766328 link

Starred by 2 users
Status: Fixed
Owner:
malaykeshav@chromium.org
Closed: Sep 2017
Cc:
osh...@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

TabStrip has entirely transparent background

Project Member Reported by w...@chromium.org, Sep 18 2017 
Chrome Version: 63.0.3218.0
OS: ChromeOS Pixel

What steps will reproduce the problem?
(1) Open a tab.
(2) Press the full-screen button to cause the TabStrip to auto-hide.
(3) Move the cursor to cause the TabStrip to show again.

What is the expected result?

Expect that the tab-strip has a background (e.g. the user's chosen theme).

What happens instead?

Instead the tab-strip's background is completely transparent.

Comment 1 by w...@chromium.org, Sep 18 2017

Screenshot 2017-09-18 at 14.19.12.png
185 KB View Download

Comment 2 by sky@chromium.org, Sep 18 2017

Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
Sammie, is this related to your recent changes?

Comment 3 by sammiequon@chromium.org, Sep 19 2017

Owner: malaykeshav@chromium.org
Bisected it down to https://chromium.googlesource.com/chromium/src/+/59d036e44fc3b9ecf7f3e5f8365b3c9e8146b7ab%5E%21/#F0, so assigning to malaykeshav@.

Confirmed on ToT if you disable "Enable pixel canvas recording" flag, the toolbar is as expected.

Comment 4 by malaykeshav@chromium.org, Sep 19 2017

Cc: osh...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77323ee6040fa540fa5f8e39a8253c5ba653e296

commit 77323ee6040fa540fa5f8e39a8253c5ba653e296
Author: F#m <malaykeshav@chromium.org>
Date: Thu Sep 21 02:34:43 2017

TopContainerView now passes the correct paint info during immersive mode

During immersive mode, TopContainerView relies on
BrowserNonClientFrameView to paint parts of TopContainerView. This
requires a call to BrowserNonClientFrameView::Paint() from
TopContainerView.

This patch fixes the call by passing in the correct parameters for
paint. It also removes the method from PaintInfo that is no longer
required post this change.

Bug:  766328 
Change-Id: I5bb16c80cc01503959c040c476f6cd60b5975c5d
Component: ChromeOS, TopContainer Browser, TabStrip, Paint
Reviewed-on: https://chromium-review.googlesource.com/673764
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503325}
[modify] https://crrev.com/77323ee6040fa540fa5f8e39a8253c5ba653e296/chrome/browser/ui/views/frame/top_container_view.cc
[modify] https://crrev.com/77323ee6040fa540fa5f8e39a8253c5ba653e296/ui/views/paint_info.cc
[modify] https://crrev.com/77323ee6040fa540fa5f8e39a8253c5ba653e296/ui/views/paint_info.h

Comment 6 by malaykeshav@chromium.org, Sep 21 2017

Status: Fixed (was: Started)
►

Sign in to add a comment