New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766325 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Sep 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 766193



Sign in to add a comment

[Findit] don't auto commit a revert if the original CL is a DEPS auto roll

Project Member Reported by chanli@chromium.org, Sep 18 2017 
Findit should continue create reverts for those CLs but not commit them.

We should enable committing those reverts later when Findit can also automatically stop the auto rollers.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7b149baf82e208268d460e1375804a3554d5fda5

commit 7b149baf82e208268d460e1375804a3554d5fda5
Author: Chan <chanli@chromium.org>
Date: Tue Sep 19 00:34:32 2017

[Findit] Don't auto commit revert of DEPS autorolls.

Checks the author's email to filter out those reverts for auto roller created CLs, and bail out of auto commit.

Bug:  766325 
Change-Id: I40bb24b81c6df8ccb0d649de3e69f8d92397a0a7
Reviewed-on: https://chromium-review.googlesource.com/671129
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/services/revert.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/libs/gitiles/change_log.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/services/test/revert_test.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/waterfall/test/suspected_cl_util_test.py
[modify] https://crrev.com/7b149baf82e208268d460e1375804a3554d5fda5/appengine/findit/waterfall/suspected_cl_util.py

Comment 2 by chanli@chromium.org, Sep 23 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment