New issue
Advanced search Search tips

Issue 766315 link

Starred by 1 user
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate unnecessary includes, to improve compile time

Reported by msten...@opera.com, Sep 18 2017 
The number of compilation units in Chromium is constantly increasing. At the same time, the amount of code in header files increases. Over time, we get more and more compilation units, and each of them includes more and more. This leads to O(n^2) time complexity when it comes to building Chromium. This even matters when making distributed builds (with GOMA, icecc, etc.), but it's obviously even more critical when building on a single computer.

Therefore it's important to forward-declare what we can, and avoid unnecessary includes..
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b903e3af17a547e28a1fd54d3ecb1528931db92e

commit b903e3af17a547e28a1fd54d3ecb1528931db92e
Author: Morten Stenshorne <mstensho@opera.com>
Date: Tue Sep 19 01:06:06 2017

Include less from ContainerNode.h

Bug: 766315
Change-Id: I791ae5a12f0602c95194a60659e29e572dce5c8a
Reviewed-on: https://chromium-review.googlesource.com/668441
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502744}
[modify] https://crrev.com/b903e3af17a547e28a1fd54d3ecb1528931db92e/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/b903e3af17a547e28a1fd54d3ecb1528931db92e/third_party/WebKit/Source/core/dom/ContainerNode.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92e6917444d7d2a88a87c1ac5137b271f35c7a6

commit a92e6917444d7d2a88a87c1ac5137b271f35c7a6
Author: Morten Stenshorne <mstensho@opera.com>
Date: Tue Sep 19 19:39:02 2017

Include less from platform/geometry/ headers.

In particular, avoid <algorithm>.

Specifying the default template parameters to Vector in Forward.h
means that we can no longer specify them along with the template
definition.

Bug: 766315
Change-Id: I62eeaf5da82f59431d68011f904a1fcaf9f93f81
Reviewed-on: https://chromium-review.googlesource.com/668367
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502920}
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/DoublePoint.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/DoublePoint.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/DoubleSize.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatBox.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatBox.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatPoint.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatRect.h
[add] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatRectOutsets.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatRectOutsets.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatSize.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/FloatSize.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/IntRect.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/IntRect.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/LayoutPoint.cpp
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/LayoutPoint.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/geometry/LayoutSize.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/wtf/Forward.h
[modify] https://crrev.com/a92e6917444d7d2a88a87c1ac5137b271f35c7a6/third_party/WebKit/Source/platform/wtf/Vector.h
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5984817b816ec53e9a175d3ce78799f162ad7bb8

commit 5984817b816ec53e9a175d3ce78799f162ad7bb8
Author: Morten Stenshorne <mstensho@opera.com>
Date: Wed Sep 20 12:03:51 2017

Don't include Document.h from CSSParserContext.h

Around 330 fewer dependencies on Document.h.

Bug: 766315
Change-Id: I48cb525c176b27463f06090bad125bb2025b5759
Reviewed-on: https://chromium-review.googlesource.com/668444
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#503117}
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/dom/NamedNodeMap.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/dom/ShadowRoot.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/HTMLDetailsElement.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/HTMLElement.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/HTMLLegendElement.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/custom/CustomElementDefinition.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/svg/SVGAnimatedEnumerationBase.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/svg/SVGStopElement.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeDisplayElement.cpp
[modify] https://crrev.com/5984817b816ec53e9a175d3ce78799f162ad7bb8/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea1bc8147160222bba2c071ee1761fd8be07e2a

commit 9ea1bc8147160222bba2c071ee1761fd8be07e2a
Author: Morten Stenshorne <mstensho@opera.com>
Date: Thu Sep 21 19:49:50 2017

Remove unnecessary includes from UseCounter.h

Especially v8.h is heavy.

Bug: 766315
Change-Id: I9bd71910607f829fd0f71d8de0e64d3dbc741461
Reviewed-on: https://chromium-review.googlesource.com/669019
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#503538}
[modify] https://crrev.com/9ea1bc8147160222bba2c071ee1761fd8be07e2a/third_party/WebKit/Source/core/frame/UseCounter.h
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6

commit ba103ac99ee9a7d48b64bdb25eb63518392b7bc6
Author: Morten Stenshorne <mstensho@opera.com>
Date: Sat Sep 23 17:00:39 2017

Include less from Element.h

Bug: 766315
Change-Id: I16b36710368f24b76c7598f9956e3cd80c95f4fc
Reviewed-on: https://chromium-review.googlesource.com/668443
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503941}
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/dom/events/EventDispatcher.cpp
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/core/layout/LayoutMenuList.h
[modify] https://crrev.com/ba103ac99ee9a7d48b64bdb25eb63518392b7bc6/third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/888713f663d3d53f00b0cdd6983fbb661be7c79c

commit 888713f663d3d53f00b0cdd6983fbb661be7c79c
Author: Morten Stenshorne <mstensho@opera.com>
Date: Thu Sep 28 00:55:02 2017

Don't include UseCounter.h from CSSParserContext.h and others.

public/platform/web_feature.mojom-blink.h is heavy.
Avoid it when possible.

Break the WebFeature defintion out of UseCounter.h and also make that
enum forward-declarable. There are quite a few translation units that
don't need to deal with UseCounter, just because they need to name a
web feature. And then there are also some places where we just need to
have the type forward-declared, such as in CSSParserContext.h

This reduces the number translation units that depend on UseCounter.h
by about 1601 compilation units, which is ~56%.

It seems that most translation units that include UseCounter.h really
need the WebFeature definition as well, so at least for now, it will
be included there.

Bug: 766315
Change-Id: I1cc0ee843373eb407c424ecd3c03c0f9080770bd
Reviewed-on: https://chromium-review.googlesource.com/669020
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504840}
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIObjectPosition.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspectiveOrigin.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundUtils.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSPropertyTransformUtils.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIBackground.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/frame/UseCounter.h
[add] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/frame/WebFeature.h
[add] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/frame/WebFeatureForward.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/DateInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/EmailInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/InputType.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/MonthInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/NumberInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/PasswordInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/SubmitInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/TelephoneInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/TextInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/URLInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/html/forms/WeekInputType.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/loader/BaseFetchContext.cpp
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/loader/BaseFetchContext.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/888713f663d3d53f00b0cdd6983fbb661be7c79c/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2

commit 8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2
Author: Morten Stenshorne <mstensho@opera.com>
Date: Tue Oct 03 18:14:15 2017

Avoid inclusion of <algorithm> from popular header files when possible.

It's heavy to compile.

Bug: 766315
Change-Id: I0182fe1b9c8e8e6bd2024cb71bab7e3fcc501246
Reviewed-on: https://chromium-review.googlesource.com/695106
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506106}
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/core/css/StylePropertySet.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.cpp
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/core/layout/TextDecorationOffsetBase.cpp
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/core/style/BorderValue.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/core/style/GridArea.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/animation/AnimationUtilities.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/geometry/FloatRect.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.cc
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/wtf/RefPtr.h
[modify] https://crrev.com/8a06c39c4582fbfbab6966dbb1c38a9173bfb1a2/third_party/WebKit/Source/platform/wtf/text/WTFString.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb

commit af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb
Author: Morten Stenshorne <mstensho@opera.com>
Date: Mon Oct 09 23:11:13 2017

Eliminate some unnecessary includes in WebKit/public/

Mostly about reducing the need for <algorithm>, which is heavy, but removed
some other includes as well.

Bug: 766315
Change-Id: Id92c08e96566dfe5c780f6a101dbfdeb43aa4ac3
Reviewed-on: https://chromium-review.googlesource.com/693236
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#507523}
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/content/common/cursors/webcursor.cc
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/content/renderer/history_serialization.cc
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/third_party/WebKit/public/platform/WebFloatSize.h
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/third_party/WebKit/public/platform/WebVector.h
[modify] https://crrev.com/af5e52786ffa7b8e7767ad23a0fd63e6969a0dcb/third_party/WebKit/public/web/WebFrameOwnerProperties.h

Comment 9 by dtapu...@chromium.org, Jan 22 2018

Components: Build
►

Sign in to add a comment