New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766313 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Download progress always starts with -1% when installing apps from chrome webstore

Project Member Reported by sdantul...@chromium.org, Sep 18 2017

Issue description

Google Chrome	62.0.3202.27 (Official Build) dev (64-bit)
Revision	0
Platform	9901.20.0 (Official Build) dev-channel caroline

What steps will reproduce the problem?
(1) Open chrome webstore
(2) Select any app and click on "Add to Chrome"
(3) See download notification

What is the expected result?
Download progress should start with 0%

What happens instead?
Download progress starts with -1%
 

Comment 2 by tetsui@chromium.org, Sep 19 2017

Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by tetsui@chromium.org, Sep 19 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2b6254e95e1c231946af86e03d2d170510d1d1

commit ff2b6254e95e1c231946af86e03d2d170510d1d1
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Sep 20 01:58:48 2017

Support infinite progress in new style notification.

There was an undocumented behavior that you can make progress
notification with infinite progress bar by setting negative values to
RichNotificationData.progress.
This behavior is used in DownloadItemNotification.

TEST=manual
BUG= 766313 

Change-Id: Ic1055866abeef5e1e7e44c732e5406725801373d
Reviewed-on: https://chromium-review.googlesource.com/672173
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503024}
[modify] https://crrev.com/ff2b6254e95e1c231946af86e03d2d170510d1d1/ui/message_center/notification.h
[modify] https://crrev.com/ff2b6254e95e1c231946af86e03d2d170510d1d1/ui/message_center/views/notification_view_md.cc

Comment 5 by tetsui@chromium.org, Sep 20 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
10009.0.0, 63.0.3230.0
Labels: Merge-Request-62
Status: Started (was: Verified)
I got a request to fix this to m62 and request a merge.
Cc: bhthompson@chromium.org
My mistake here, I thought this was already merged to M62 based on the discussion over at https://listnr.corp.google.com/report/73692233557

Bernie, how likely are we to be able to merge this small change in the case of another M62 stable build?
Labels: -Merge-Request-62 Merge-Approved-62
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f2a57c1d8326e6b39a02219dc30fa379d085987

commit 2f2a57c1d8326e6b39a02219dc30fa379d085987
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Nov 08 19:40:05 2017

Support infinite progress in new style notification.

There was an undocumented behavior that you can make progress
notification with infinite progress bar by setting negative values to
RichNotificationData.progress.
This behavior is used in DownloadItemNotification.

TEST=manual
BUG= 766313 

Change-Id: Ic1055866abeef5e1e7e44c732e5406725801373d
Reviewed-on: https://chromium-review.googlesource.com/672173
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503024}(cherry picked from commit ff2b6254e95e1c231946af86e03d2d170510d1d1)
Reviewed-on: https://chromium-review.googlesource.com/758521
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#782}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/2f2a57c1d8326e6b39a02219dc30fa379d085987/ui/message_center/notification.h
[modify] https://crrev.com/2f2a57c1d8326e6b39a02219dc30fa379d085987/ui/message_center/views/notification_view_md.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ChromeOS 9901.77.0, 62.0.3202.97 stable-channel

Sign in to add a comment