Harmonize all Edit Bookmark dialogs [needs mocks] |
|||||||
Issue descriptionThis bug covers harmonizing the various Bookmark Editor dialogs (that is, instances of BookmarkEditorView: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_editor_view.h?q=BookmarkEditorView&l=48). Add Page from Bookmark Dialogue: https://screenshot.googleplex.com/893mm5pgLvE.png Add Folder from Bookmark Bar: https://screenshot.googleplex.com/7YUWiSqHghG.png Bookmark All Tabs: https://screenshot.googleplex.com/hJJjFZWD7pF.png
,
Sep 20 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e172457732b437d4e97b85bf763c91790e1897cc commit e172457732b437d4e97b85bf763c91790e1897cc Author: Trent Apted <tapted@chromium.org> Date: Thu Oct 12 12:45:55 2017 Ensure Bookmark-related buttons, menu items and dialog titles have titlecase strings. Currently, some don't. Note we can't assume words like "Edit" translate to a single word in every language (e.g. Vietnamese - "Chỉnh sửa"). Field labels, spoken feedback, and placeholder strings do not get titlecase. Remove colons from field labels in the edit bookmark dialog to match the add bookmark bubble. Bug: 766309 Change-Id: Ia23e8252147bf9b81ce1396d395a360a452725ee Reviewed-on: https://chromium-review.googlesource.com/710894 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#508322} [modify] https://crrev.com/e172457732b437d4e97b85bf763c91790e1897cc/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/e172457732b437d4e97b85bf763c91790e1897cc/components/bookmark_component_strings.grdp
,
Dec 14 2017
Issue 766304 has been merged into this issue.
,
Dec 14 2017
Issue 766306 has been merged into this issue.
,
Dec 14 2017
,
Dec 14 2017
Consolidating the bugs for BookmarkEditorView, since it looks to me they'll be highly related.
,
Dec 14 2017
Actually can we get mocks for these dialogs? The screenshots are the cocoa versions; the views versions look basically fine to me right now, so I'm wondering if there's anything to do (especially since we want to replace them eventually).
,
Dec 20 2017
There's no bandwidth to create mocks for this surface, especially if they're on track to being removed (yay). Edit bookmarks in 65.0.3299.2 LGTM.
,
Dec 20 2017
Great! Closing this, as there's nothing more to do. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pkasting@chromium.org
, Sep 20 2017