Harmony - Extensions: Media Galleries Configuration View |
|||||||
Issue descriptionWe need to harmonize (move to MD) different dialogues related to Extensions. Extensions: Media Galleries Config View CS: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h?q=MediaGalleriesDialogViews&l=28
,
Sep 18 2017
,
Sep 20 2017
Do we have a screenshot or mock of this?
,
Sep 22 2017
I attached a screenshot of what you get if you run the BrowserDialogTest, but it's not very illuminating as to what this dialog is actually used for. The code that invokes it normally is really confusing.
,
Oct 30 2017
,
Nov 10 2017
[Extensions Triage] Assigning to pkasting@ for further triage.
,
Nov 29 2017
This is used to pick which locations on the user's filesystem are treated as "media galleries" (e.g. the user's Pictures folder). To see this dialog in the wild, install https://chrome.google.com/webstore/detail/media-gallery-sample/lidepfgfmameopopgagobnpndcnfgbnk , run, and hit "Select galleries". Screenshot attached.
,
Nov 29 2017
Most obvious thing that sticks out to me is the close button (I think this dialog is supposed to be modal so it should have none?). Need to check spacing as well.
,
Feb 13 2018
Load balance
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6159cc652681c439663e8823135effe968b97077 commit 6159cc652681c439663e8823135effe968b97077 Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Feb 21 19:05:35 2018 Harmony: Removed the close button on the media-galleries dialog view. Bug: 766300 Change-Id: I5a900c9542afccdfb33acc7dba90993bfdd4cce3 Reviewed-on: https://chromium-review.googlesource.com/929201 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#538175} [modify] https://crrev.com/6159cc652681c439663e8823135effe968b97077/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc [modify] https://crrev.com/6159cc652681c439663e8823135effe968b97077/chrome/browser/ui/views/extensions/media_galleries_dialog_views.h
,
Feb 28 2018
After UX review, bounce back if more work needed.
,
Apr 9 2018
Clearing my ownership of Platform>Extension bugs. CC'ing Mark for reassignment/re-triaging |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by abdulsyed@chromium.org
, Sep 18 2017