Harmony - Install extension from store |
||||
Issue descriptionWe need to harmonize (move to MD) different dialogues related to Extensions. Offstore Extension dialogue: https://drive.google.com/file/d/0B1VXa3kr2lYjZ1Fpc2Q3bTZ3Sk0/view CS: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/extensions/extension_install_dialog_view.h?q=ExtensionInstallDialogView&sq=package:chromium&l=39
,
Sep 20 2017
I think this is the "install from the store" dialog? (Seems different than a dialog focused on extensions not-from-the-store would be, do we have one of those?)
,
Sep 21 2017
https://drive.google.com/file/d/0B1VXa3kr2lYjZ1Fpc2Q3bTZ3Sk0/view shows the "*inline* extension install dialog". I think we are using Issue 605657 for that. This is the dialog that shows when a website wants to link "directly" to their extension in the webstore. There is also the "*external* extension install" dialog. This is shown when Chrome detects at startup that an extension has been forcibly installed into Chrome's user data dir (e.g. by a third party installer, when you forget to untick that "also install other stuff I never asked for" checkbox). That looks like https://bugs.chromium.org/p/chromium/issues/attachment?aid=302157&inline=1 . Note this extension must *also* live in the webstore - Chrome blacklists extensions that don't have a webstore presence. It just wasn't installed via a webstore download in this case. There is *also* the "*remote* extension install dialog" dialog. This is shown when Chrome runs with a corp policy that changes (or was newly detected), and that policy directs chrome to automatically install an extension without prompting. This looks like https://bugs.chromium.org/p/chromium/issues/attachment?aid=301422&inline=1 (And of course there's the regular install dialogs you see at the webstore. And the update dialog. And removal dialogs. And "has upgraded permissions" dialog.)
,
Sep 22 2017
Looks like all the right folks are on this already. Assigning to pkasting@ to find a proper owner in order to get it out of extensions triage. :)
,
Sep 22 2017
Going through and making sure there is only one bug for each type of extensions dialog. For reference: bug 60565 is for the regular "install an extension?" "extension installed by server" is a GlobalErrorWithStandardBubble bug 654124 is for the "extension was installed externally" and the "requires new permissions to re-enable" dialogs bug 654133 is for extension removal
,
Sep 22 2017
That should be " bug 605657 " for the regular "install an extension" dialog |
||||
►
Sign in to add a comment |
||||
Comment 1 by abdulsyed@chromium.org
, Sep 18 2017