New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766277 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Apr 2018
Cc:
pbos@chromium.org
tapted@chromium.org
pkasting@chromium.org
bettes@chromium.org
█ rpop@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug


Participants' hotlists:
Harmony-Ready-For-Review


Sign in to add a comment

Harmony UI - Harmonizing Try Chrome on iPhone screen

Project Member Reported by abdulsyed@chromium.org, Sep 18 2017

Comment 1 by bsep@chromium.org, Dec 14 2017

Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
Load balancing
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5693a6ca1759af37eaa5843e26594c8a0054eab8

commit 5693a6ca1759af37eaa5843e26594c8a0054eab8
Author: Peter Boström <pbos@chromium.org>
Date: Thu Feb 01 03:10:19 2018

Harmonize iOS promo dialog.

* Removes fixed label width.
* Adds context and style to promo label.
* Removes content view inside BookmarkBubbleView so that the promo view
  isn't being enlargened due to the invisible content dimensions.

Bug:  chromium:766277 
Change-Id: Ieadd706373e4b67d0bcf5fb62a1b78fd1ff67703
Reviewed-on: https://chromium-review.googlesource.com/890055
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533538}
[modify] https://crrev.com/5693a6ca1759af37eaa5843e26594c8a0054eab8/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/5693a6ca1759af37eaa5843e26594c8a0054eab8/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/5693a6ca1759af37eaa5843e26594c8a0054eab8/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/5693a6ca1759af37eaa5843e26594c8a0054eab8/chrome/browser/ui/views/passwords/password_pending_view.cc

Comment 3 by pbos@chromium.org, Feb 1 2018

Cc: pbos@chromium.org
Owner: bettes@chromium.org
Attaching screenshot, this still says "password" instead of "bookmark" if invoked from the password manager.
ios-promo.png
19.2 KB View Download

Comment 4 by bettes@chromium.org, Apr 9 2018 

We might not be supporting this feature anymore. Will follow back once confirmed.

Comment 5 by bettes@chromium.org, Apr 10 2018

Owner: pbos@chromium.org
Decision is to keep this code and UI around. 

Formatting LGTM. Assigning back to pbos@ for final tweaks.

Comment 6 by pbos@chromium.org, Apr 10 2018

Status: Fixed (was: Assigned)
Don't think there are any tweaks pending, so I think we're done?
►

Sign in to add a comment