New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766268 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ shrike@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Provide Detailed Fullscreen Metrics

Project Member Reported by spqc...@chromium.org, Sep 18 2017 
Provide more detailed metrics on Chrome Mac Fullscreen.
We should track if the user entered fullscreen for tab contents or the browser
In addition, we should track the menu item "Always Show Toolbar in Full Screen"
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a

commit c43a18e85fe1c6f718273977c1b68c9d1fbcf51a
Author: spqchan <spqchan@chromium.org>
Date: Mon Oct 02 09:00:11 2017

[Mac] Fullscreen Metrics

Add the following metrics for Chrome Mac Fullscreen:
- Fullscreen source (Browser, Tab, Extension)
- Fullscreen toolbar style (Shown, Hidden, None)

This CL also refactors and renames a couple of
confusing methods in FullscreenToolbarController.

Testing: BrowserWindowControllerTest.FullscreenHistogram

Bug:  766268 
Change-Id: Iff36e448a0fc1385c7392088699d91a2be94fd91
Reviewed-on: https://chromium-review.googlesource.com/688224
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505561}
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_visibility_lock_controller.mm
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c43a18e85fe1c6f718273977c1b68c9d1fbcf51a/tools/metrics/histograms/histograms.xml

Comment 2 by spqc...@chromium.org, Oct 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment