New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Provide metrics on the browser's upgrade status

Project Member Reported by spqc...@chromium.org, Sep 18 2017

Issue description

Provide a metric to track how many users are in a browser state that requires update.
The metric should contain details such as the current annoyance level (low, high, etc).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7ef125843219982bd4638cee170e459da9fd36

commit ab7ef125843219982bd4638cee170e459da9fd36
Author: spqchan <spqchan@chromium.org>
Date: Thu Sep 21 02:39:29 2017

Provide Metrics on the Browser's Upgrade State

Add metrics that tracks if the user's browser is outdated.
The metric contains details on the upgrade level, which is
represented by the upgrade detector's
"UpgradeAnnoyanceLevel".

Tests: upgrade_metrics_provider_unittest.cc

Bug:  766246 
Change-Id: Ic5a6f8c72a46fda24cb4b00db6380406d460d2ef
Reviewed-on: https://chromium-review.googlesource.com/657969
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503332}
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/BUILD.gn
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/metrics/chrome_metrics_service_client.cc
[add] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/metrics/upgrade_metrics_provider.cc
[add] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/metrics/upgrade_metrics_provider.h
[add] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/metrics/upgrade_metrics_provider_unittest.cc
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/browser/upgrade_detector.h
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/chrome/test/BUILD.gn
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ab7ef125843219982bd4638cee170e459da9fd36/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Request-62 M-62
Status: Started (was: Fixed)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 22 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks - can you please comment on if this is well tested in canary? Is it a safe merge overall with full unit testing?
Yes, it's tested and safe. There's also a unit test for this.
Labels: -Merge-Review-62 Merge-Approved-62
Approved. branch:3202
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 22 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9

commit ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9
Author: spqchan <spqchan@chromium.org>
Date: Fri Sep 22 20:23:26 2017

Provide Metrics on the Browser's Upgrade State

Add metrics that tracks if the user's browser is outdated.
The metric contains details on the upgrade level, which is
represented by the upgrade detector's
"UpgradeAnnoyanceLevel".

Tests: upgrade_metrics_provider_unittest.cc

(cherry picked from commit ab7ef125843219982bd4638cee170e459da9fd36)

Bug:  766246 
Change-Id: Ic5a6f8c72a46fda24cb4b00db6380406d460d2ef
Reviewed-on: https://chromium-review.googlesource.com/657969
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503332}
Reviewed-on: https://chromium-review.googlesource.com/679289
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#405}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/BUILD.gn
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/metrics/chrome_metrics_service_client.cc
[add] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/metrics/upgrade_metrics_provider.cc
[add] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/metrics/upgrade_metrics_provider.h
[add] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/metrics/upgrade_metrics_provider_unittest.cc
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/browser/upgrade_detector.h
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/chrome/test/BUILD.gn
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ce6c0c0a628b38f6463bd99c2a00bf0d9852bfa9/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment