Chrome Android: Seccomp violation from process_vm_readv in aosp/master |
|||||||||
Issue descriptionFrom b/65638294: After https://android-review.googlesource.com/c/platform/art/+/374049, ART issues the process_vm_readv() system call. That CL hit aosp/master, so it will affect the internal automerged downstream targets too. We need to permit this for M61. We can restrict the target to 0 and the sandbox PID.
,
Sep 18 2017
Issue 766127 claims this crash also happens on 8.0.0 which is unexpected...
,
Sep 18 2017
Yeah this also affects the publicly released 8.0.0, not just future versions - we were mistaken.
,
Sep 18 2017
For some reason, this was not reproducing on ToT M63, but I was able to check out 61 and verify the fix there. CL up at https://chromium-review.googlesource.com/c/chromium/src/+/671556.
,
Sep 18 2017
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7844944fc6377795aaa2f9087bd4a285482ec4c3 commit 7844944fc6377795aaa2f9087bd4a285482ec4c3 Author: Robert Sesek <rsesek@chromium.org> Date: Mon Sep 18 23:38:13 2017 [Android] Allow __NR_process_vm_readv under Seccomp. Bug: 766245 Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d Reviewed-on: https://chromium-review.googlesource.com/671556 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#502714} [modify] https://crrev.com/7844944fc6377795aaa2f9087bd4a285482ec4c3/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/727c03b821786f8256b01165af8e8820c7eea7e6 commit 727c03b821786f8256b01165af8e8820c7eea7e6 Author: Robert Sesek <rsesek@chromium.org> Date: Mon Sep 18 23:42:16 2017 [Android] Allow __NR_process_vm_readv under Seccomp. (cherry picked from commit 7844944fc6377795aaa2f9087bd4a285482ec4c3) Bug: 766245 Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d Reviewed-on: https://chromium-review.googlesource.com/671556 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502714} Reviewed-on: https://chromium-review.googlesource.com/671611 Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1229} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/727c03b821786f8256b01165af8e8820c7eea7e6/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49ddf92e7a985c2ff22a49f25c26708d325cf007 commit 49ddf92e7a985c2ff22a49f25c26708d325cf007 Author: Robert Sesek <rsesek@chromium.org> Date: Mon Sep 18 23:42:17 2017 [Android] Allow __NR_process_vm_readv under Seccomp. (cherry picked from commit 7844944fc6377795aaa2f9087bd4a285482ec4c3) Bug: 766245 Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d Reviewed-on: https://chromium-review.googlesource.com/671556 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502714} Reviewed-on: https://chromium-review.googlesource.com/671612 Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#314} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/49ddf92e7a985c2ff22a49f25c26708d325cf007/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 18 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a53e5344e1b5f1d7fe5ff2e0677947e31fa310d commit 6a53e5344e1b5f1d7fe5ff2e0677947e31fa310d Author: Tao Bai <michaelbai@chromium.org> Date: Tue Sep 19 00:05:53 2017 Revert "[Android] Allow __NR_process_vm_readv under Seccomp." This reverts commit 7844944fc6377795aaa2f9087bd4a285482ec4c3. Reason for revert: it broke x86 builder https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/22715 Original change's description: > [Android] Allow __NR_process_vm_readv under Seccomp. > > Bug: 766245 > Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d > Reviewed-on: https://chromium-review.googlesource.com/671556 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502714} TBR=torne@chromium.org,rsesek@chromium.org Change-Id: I31ab91b3572c1e109699ceabcdfbd06cc0c54e39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766245 Reviewed-on: https://chromium-review.googlesource.com/671658 Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502723} [modify] https://crrev.com/6a53e5344e1b5f1d7fe5ff2e0677947e31fa310d/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 19 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d083108aa02767bf7f721fcdc76acf5f41dc7d9 commit 5d083108aa02767bf7f721fcdc76acf5f41dc7d9 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Sep 19 14:26:00 2017 [BRANCH ONLY] Fix x86 Android build after Ic494f526c1b8d15483ca7e9a97d9f044f276c26d. This adds an #include to resolve the missing definition of __NR_process_vm_readv on x86. Bug: 766245 , 766400 Change-Id: Iebd67b5d03f84d72663ebc4a116253d2c8d6223e Reviewed-on: https://chromium-review.googlesource.com/672607 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1236} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5d083108aa02767bf7f721fcdc76acf5f41dc7d9/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 19 2017
verified on pixel / opm1.170918.001 vs webview 61.0.3163.98 using step from b/65638294
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d698a9b567a559739aad4349a433ba0ef071583d commit d698a9b567a559739aad4349a433ba0ef071583d Author: Robert Sesek <rsesek@chromium.org> Date: Tue Sep 19 18:11:00 2017 [BRANCH ONLY] Fix x86 Android build after Ic494f526c1b8d15483ca7e9a97d9f044f276c26d. This adds an #include to resolve the missing definition of __NR_process_vm_readv on x86. (cherry picked from commit 5d083108aa02767bf7f721fcdc76acf5f41dc7d9) Bug: 766245 , 766400 Change-Id: Iebd67b5d03f84d72663ebc4a116253d2c8d6223e Reviewed-on: https://chromium-review.googlesource.com/672607 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3163@{#1236} Cr-Original-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} Reviewed-on: https://chromium-review.googlesource.com/673223 Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#325} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/d698a9b567a559739aad4349a433ba0ef071583d/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34399a4af545f75902dc4a162acd7e442c60c5a2 commit 34399a4af545f75902dc4a162acd7e442c60c5a2 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Sep 19 19:51:42 2017 Reland "[Android] Allow __NR_process_vm_readv under Seccomp." This is a reland of 7844944fc6377795aaa2f9087bd4a285482ec4c3 Original change's description: > [Android] Allow __NR_process_vm_readv under Seccomp. > > Bug: 766245 > Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d > Reviewed-on: https://chromium-review.googlesource.com/671556 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502714} Bug: 766245 , 766400 Change-Id: I369421422f8bced50a5577167b5ccb59f9901f3d Reviewed-on: https://chromium-review.googlesource.com/672643 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#502924} [modify] https://crrev.com/34399a4af545f75902dc4a162acd7e442c60c5a2/sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc
,
Sep 19 2017
,
Sep 19 2017
verified on pixel / opm1.170918.001 vs webview 62.0.3202.28 using step from b/65638294 issue repro on webview 62.0.3202.27 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by boliu@chromium.org
, Sep 18 2017