New issue
Advanced search Search tips

Issue 766235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Despite having JOB_RETRIES set in the control file, jobs never retry on moblab

Project Member Reported by haddowk@chromium.org, Sep 18 2017

Issue description


Before the job retries was set to a default of 3 but we are not using data to tweak this number for more flaky tests.   

When trying to test out this feature it was noticed the moblab actually never retries a test
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87f4bce04d06323341d38a807367de5e529c636d

commit 87f4bce04d06323341d38a807367de5e529c636d
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Sep 18 19:19:43 2017

[moblab] Turn on job retries when creating the suite.

Job retries defaults to false so the settings in the control files
were being ignored, switch on retries.

BUG= chromium:766235 
TEST=local moblab tests

Change-Id: I81fccb328c7dcc68cdfc06326e9527044ade5ac2
Reviewed-on: https://chromium-review.googlesource.com/671631
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/87f4bce04d06323341d38a807367de5e529c636d/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9d1db417848092bdb5add994421ea43a15d38a14

commit 9d1db417848092bdb5add994421ea43a15d38a14
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Sep 18 23:48:51 2017

[moblab] Turn on job retries when creating the suite.

Job retries defaults to false so the settings in the control files
were being ignored, switch on retries.

BUG= chromium:766235 
TEST=local moblab tests

Change-Id: I81fccb328c7dcc68cdfc06326e9527044ade5ac2
Reviewed-on: https://chromium-review.googlesource.com/671629
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/9d1db417848092bdb5add994421ea43a15d38a14/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e9701b0c0aa0835a424f46b90a03c819f2ff901

commit 6e9701b0c0aa0835a424f46b90a03c819f2ff901
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Sep 19 08:14:04 2017

[moblab] Turn on job retries when creating the suite.

Job retries defaults to false so the settings in the control files
were being ignored, switch on retries.

BUG= chromium:766235 
TEST=local moblab tests

Change-Id: I81fccb328c7dcc68cdfc06326e9527044ade5ac2
Reviewed-on: https://chromium-review.googlesource.com/671629
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 9d1db417848092bdb5add994421ea43a15d38a14)
Reviewed-on: https://chromium-review.googlesource.com/672045
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/6e9701b0c0aa0835a424f46b90a03c819f2ff901/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/81559421756d7b16754dc4a2a9063b863d62209a

commit 81559421756d7b16754dc4a2a9063b863d62209a
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Sep 19 08:21:37 2017

[moblab] Add some more options that are needed for retry to work

Turns out you need to set the max_retries, and wait for results
flags for the retries to actually work.

BUG= chromium:766235 ,chromium:675041
TEST=local moblab runs

Change-Id: I780abc1e316f6b77bc67802c8d7d21f560503ef7
Reviewed-on: https://chromium-review.googlesource.com/671773
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/81559421756d7b16754dc4a2a9063b863d62209a/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/245d826d4f63b42acace1604ff44e0c41f470a6b

commit 245d826d4f63b42acace1604ff44e0c41f470a6b
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Sep 19 08:23:32 2017

[moblab] Add some more options that are needed for retry to work

Turns out you need to set the max_retries, and wait for results
flags for the retries to actually work.

BUG= chromium:766235 ,chromium:675041
TEST=local moblab runs

Change-Id: I780abc1e316f6b77bc67802c8d7d21f560503ef7
Reviewed-on: https://chromium-review.googlesource.com/672046
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/245d826d4f63b42acace1604ff44e0c41f470a6b/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/62c08670618cddce55b9f128d326251e065c7c01

commit 62c08670618cddce55b9f128d326251e065c7c01
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Sep 19 12:25:14 2017

[moblab] Add some more options that are needed for retry to work

Turns out you need to set the max_retries, and wait for results
flags for the retries to actually work.

BUG= chromium:766235 ,chromium:675041
TEST=local moblab runs

Change-Id: I780abc1e316f6b77bc67802c8d7d21f560503ef7
Reviewed-on: https://chromium-review.googlesource.com/671879
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/62c08670618cddce55b9f128d326251e065c7c01/frontend/afe/moblab_rpc_interface.py

Status: Fixed (was: Untriaged)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment