New issue
Advanced search Search tips

Issue 766227 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue gerrit:7656


Previous locations:
gerrit:7231


Sign in to add a comment

CL description doesn't display more than five bug links.

Project Member Reported by alex...@chromium.org, Sep 15 2017

Issue description

Example: https://chromium-review.googlesource.com/c/chromium/src/+/661997

The first five bugs on the "Bug:" line have links, the next five do not.  When the CL landed, all ten bugs correctly posted bugdroid comments though.  
 

Comment 1 by logan@google.com, Sep 18 2017

Labels: -Type-Bug -Priority-3 Proj-Gerrit-Migration
Sending this issue to chromium to own. If they end up needing some gerrit feature development done to make it feasible to accomplish this (which I suspect they will), I'd like to see a new feature request filed to specifically address that change.

Comment 2 by logan@google.com, Sep 18 2017

Project: chromium
Moved issue gerrit:7231 to now be issue chromium:766227.
Components: Infra>Codereview>Gerrit
This is due to limitations in the Gerrit "commentlink" system.

It only accepts regexes which match whole lines, and the regex has to specify the replacement of the entire line. So we've chosen to hard-code 5 replacements: http://shortn/_1zmRGHOzLe

If the commentlink system accepted something along the lines of "look for lines which match foo, and then replace match group X with Y" (as opposed to "...and then replace the whole match with Y") then we could generalize to any number of bug links.
Blockedon: gerrit:7656
Labels: -Proj-Gerrit-Migration Pri-3
Status: ExternalDependency (was: New)
Labels: Type-Bug

Sign in to add a comment